Bug 163790

Summary: FreeBSD Port java/diablo-jdk16 Patch
Product: Ports & Packages Reporter: A.J. Kehoe IV <cT2CTdJ6>
Component: Individual Port(s)Assignee: Greg Lewis <glewis>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description A.J. Kehoe IV 2012-01-02 22:20:10 UTC 
I discovered that the FreeBSD port java/diablo-jdk16 doesn't reinstall as intended.

-----BEGIN QUOTE-----
# make deinstall
===>  Deinstalling for java/diablo-jdk16
===>   Deinstalling diablo-jdk-1.6.0.07.02_18
# make reinstall
===>  Installing for diablo-jdk-1.6.0.07.02_18
===>   diablo-jdk-1.6.0.07.02_18 depends on executable: javavm - found
===>   diablo-jdk-1.6.0.07.02_18 depends on file: /usr/local/libdata/pkgconfig/xi.pc - found
===>   diablo-jdk-1.6.0.07.02_18 depends on file: /usr/local/libdata/pkgconfig/xp.pc - found
===>   diablo-jdk-1.6.0.07.02_18 depends on file: /usr/local/libdata/pkgconfig/xt.pc - found
===>   diablo-jdk-1.6.0.07.02_18 depends on file: /usr/local/libdata/pkgconfig/xtst.pc - found
===>   diablo-jdk-1.6.0.07.02_18 depends on shared library: z.4 - found
Updating time zones...mv: rename /usr/ports/java/diablo-jdk16/work/tzupdater-1.3.45-2011n/zi to /usr/ports/java/diablo-jdk16/work/diablo-jdk1.6.0_07/jre/lib/zi: No such file or directory
*** Error code 1

Stop in /usr/ports/java/diablo-jdk16.
*** Error code 1

Stop in /usr/ports/java/diablo-jdk16.
*** Error code 1

Stop in /usr/ports/java/diablo-jdk16.
-----END QUOTE-----

Fix: In the "pre-install" part of the Makefile, the required directory is moved from the work directory instead of copied.  To fix this, I replaced "MV" with "CP" and added the "-R" option.

I've attached a patch for the Makefile.

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/java/diablo-jdk16
make install
make deinstall
make reinstall
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-02 22:20:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->glewis

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-01-03 02:43:52 UTC 
glewis      2012-01-03 02:43:38 UTC

  FreeBSD ports repository

  Modified files:
    java/diablo-jdk16    Makefile 
    java/diablo-jre16    Makefile 
  Log:
  . Fix the reinstall target by using cp rather than mv for updating the
    zoneinfo files (otherwise they are no longer present during reinstall).
  
  PR:             163790
  Submitted by:   "A.J. Kehoe IV (Nanoman)" <cT2CTdJ6@nanoman.ca>
  
  Revision  Changes    Path
  1.24      +1 -1      ports/java/diablo-jdk16/Makefile
  1.24      +1 -1      ports/java/diablo-jre16/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Greg Lewis freebsd_committer freebsd_triage 2012-01-03 02:49:46 UTC 
State Changed
From-To: open->closed

Committed. Thanks!