Bug 163807

Summary: print/libgnomeprint CUPS Option Patch
Product: Ports & Packages Reporter: A.J. Kehoe IV <aE7qL1CN>
Component: Individual Port(s)Assignee: freebsd-gnome (Nobody) <gnome>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description A.J. Kehoe IV 2012-01-04 02:40:09 UTC 
After running "make config" recursively for a port that depends on print/libgnomeprint, creating an index of the ports tree will produce varying results depending on whether or not CUPS is installed at the time the index is created.  This conflicts with the conventional behaviour of the FreeBSD Ports Collection, and causes problems for ports management scripts.

Fix: In ports/print/libgnomeprint/Makefile, replace the current CUPS detection method with the "OPTIONS" variable.  This also eliminates the need for the notice in "pre-everything".

I've attached a patch with the fix I'm using.

Patch attached with submission follows:
How-To-Repeat: 1. Run "make config" recursively for a port that depends on print/libgnomeprint, and use the default options for each port.

2. Create an index of the ports tree.

3. Run "make install" for the port from step #1.

4. Create another index of the ports tree.

You'll notice that the index created in step #2 differs from the index created in step #4.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-04 02:40:19 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 A.J. Kehoe IV 2012-01-07 07:16:18 UTC 
Please cancel this PR.  I wasn't aware of this type of dependency
detection, and thought it was a bug.  Indexing is still an issue, but that
falls outside the scope of this PR.

Sorry for the noise!
Comment 3 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-01-08 18:21:41 UTC 
State Changed
From-To: open->closed

Closed by submitter's request
Comment 4 A.J. Kehoe IV 2012-04-16 16:33:01 UTC 
> Synopsis: print/libgnomeprint CUPS Option Patch
>
> State-Changed-From-To: open->closed
> State-Changed-By: rm
> State-Changed-When: Sun Jan 8 18:21:41 UTC 2012
> State-Changed-Why:
> Closed by submitter's request
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=163807

Please resurrect this PR.  It seems that, despite what I was led to
believe, FreeBSD doesn't actually have a system for handling automatic
dependencies.  This topic is now covered in the FreeBSD Porter's Handbook
under "Problems Caused by Automatic Dependencies":

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#AEN2421

The print/libgnomeprint Makefile hasn't changed since before this PR was
opened, so the patch I submitted can be committed without modification.

My thanks to everybody who gave me feedback regarding this issue,
especially the FreeBSD Ports Management Team and Warren Block.
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2012-04-16 17:29:02 UTC 
State Changed
From-To: closed->open

per submitter request
Comment 6 Jeremy Messenger freebsd_committer freebsd_triage 2012-05-20 17:48:44 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-05-20 17:48:44 UTC 
mezz        2012-05-20 16:48:35 UTC

  FreeBSD ports repository

  Modified files:
    print/libgnomeprint  Makefile 
  Log:
  Remove the auto-check dependency and able to use OPTIONS now.
  
  PR:             ports/163807
  Submitted by:   A.J. Kehoe IV (Nanoman) <aE7qL1CN@nanoman.ca>
  
  Revision  Changes    Path
  1.124     +3 -8      ports/print/libgnomeprint/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"