Bug 164035

Comment 1 Edwin Groothuis 2012-01-12 04:10:23 UTC

Responsible Changed
From-To: freebsd-ports-bugs->perl

perl@ wants this port PRs (via the GNATS Auto Assign Tool)

Comment 2 Frederic Culot 2012-01-12 05:37:37 UTC

Responsible Changed
From-To: perl->culot

I'll take it.

Comment 3 Frederic Culot 2012-01-12 12:34:31 UTC

Hi Jui-Nan,

thanks for submitting this new port.
However, it seems far from complete to me and it appears the following
items are missing:

1) All dependencies (you should have defined {BUILD,RUN}_DEPENDS)
2) LICENSE (vendor releases this module under Perl license)

Moreover, the link you provide in pkg-descr is specific to this version
whereas it should be generic to the module.

Hence I propose this updated port:

https://redports.org/browser/culot/security/p5-Authen-OATH

I ran the vendor-provided tests fine with this updated port, and
tinderbox runs returned no errors as well. You can see them here:

https://redports.org/~culot/20120112105901-1894-5396/p5-Authen-OATH-1.0.0.log
https://redports.org/~culot/20120112105901-1894-5397/p5-Authen-OATH-1.0.0.log
https://redports.org/~culot/20120112105901-1894-5398/p5-Authen-OATH-1.0.0.log

If you agree with my modifications then I will import my updated port.

Regards,
culot@

Hi,

Great! Please commit your version:)
2012-1-12 ä¸å8:34 æ¼ "Frederic Culot" <culot@freebsd.org> 寫éï¼

> Hi Jui-Nan,
>
> thanks for submitting this new port.
> However, it seems far from complete to me and it appears the following
> items are missing:
>
> 1) All dependencies (you should have defined {BUILD,RUN}_DEPENDS)
> 2) LICENSE (vendor releases this module under Perl license)
>
> Moreover, the link you provide in pkg-descr is specific to this version
> whereas it should be generic to the module.
>
> Hence I propose this updated port:
>
> https://redports.org/browser/culot/security/p5-Authen-OATH
>
> I ran the vendor-provided tests fine with this updated port, and
> tinderbox runs returned no errors as well. You can see them here:
>
>
> https://redports.org/~culot/20120112105901-1894-5396/p5-Authen-OATH-1.0.0.log
>
> https://redports.org/~culot/20120112105901-1894-5397/p5-Authen-OATH-1.0.0.log
>
> https://redports.org/~culot/20120112105901-1894-5398/p5-Authen-OATH-1.0.0.log
>
> If you agree with my modifications then I will import my updated port.
>
> Regards,
> culot@

>

Comment 5 dfilter service 2012-01-12 13:17:06 UTC

culot       2012-01-12 13:16:53 UTC

  FreeBSD ports repository

  Modified files:
    security             Makefile 
  Added files:
    security/p5-Authen-OATH Makefile distinfo pkg-descr pkg-plist 
  Log:
  The Authen::OATH module provides a Perl implementation of the
  HOTP and TOTP One Time Password algorithms as defined by OATH
  (http://www.openautentication.org).
  
  WWW: http://search.cpan.org/dist/Authen-OATH/
  
  PR:             ports/164035 (based on)
  Submitted by:   Jui-Nan Lin <jnlin@csie.nctu.edu.tw>
  
  Revision  Changes    Path
  1.1242    +1 -0      ports/security/Makefile
  1.1       +30 -0     ports/security/p5-Authen-OATH/Makefile (new)
  1.1       +2 -0      ports/security/p5-Authen-OATH/distinfo (new)
  1.1       +5 -0      ports/security/p5-Authen-OATH/pkg-descr (new)
  1.1       +5 -0      ports/security/p5-Authen-OATH/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 6 Frederic Culot 2012-01-12 13:19:38 UTC

State Changed
From-To: open->closed

New port added, with major changes.