Bug 164078

Summary:	man setuid(2): a messy sentence
Product:	Documentation	Reporter:	Taras Korenko <ds>
Component:	Books & Articles	Assignee:	Eitan Adler <eadler>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Taras Korenko 2012-01-13 07:50:07 UTC

The second paragraph under 'SECURITY CONSIDERATIONS' of man setuid(2) states: "To prevent these files from remaining open after an exec(3) call, be sure to set the close-on-exec flag is set:"

Fix: 

Rewrite to:
"..., ensure the close-on-exec flag is set:"
-- or --
"..., be sure to set the close-on-exec flag:"
-- or --
of course, your choise.
How-To-Repeat: setuid(2) man page for any OS >= 5.0
http://www.freebsd.org/cgi/man.cgi?query=setuid

Comment 1 Eitan Adler freebsd_committer

2012-01-13 10:35:00 UTC

Responsible Changed
From-To: freebsd-doc->eadler

I'll take it.

Comment 2 dfilter service freebsd_committer

2012-01-15 20:15:12 UTC

Author: eadler (ports committer)
Date: Sun Jan 15 20:14:52 2012
New Revision: 230155
URL: http://svn.freebsd.org/changeset/base/230155

Log:
  Make man page wording more clear:
  
  PR:		docs/164078
  Submitted by:	Taras <ds@ukrhub.net>
  Approved by:	bcr
  MFC after:	3 days

Modified:
  head/lib/libc/sys/setuid.2

Modified: head/lib/libc/sys/setuid.2
==============================================================================
--- head/lib/libc/sys/setuid.2	Sun Jan 15 20:04:05 2012	(r230154)
+++ head/lib/libc/sys/setuid.2	Sun Jan 15 20:14:52 2012	(r230155)
@@ -170,7 +170,7 @@ potentially sensitive data.
 .Pp
 To prevent these files from remaining open after an
 .Xr exec 3
-call, be sure to set the close-on-exec flag is set:
+call, be sure to set the close-on-exec flag:
 .Bd -literal
 void
 pseudocode(void)
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

Comment 3 Eitan Adler freebsd_committer

2012-01-16 18:45:17 UTC

State Changed
From-To: open->patched

comitted, awaiting MFC

Comment 4 dfilter service freebsd_committer

2012-03-23 22:04:06 UTC

Author: eadler
Date: Fri Mar 23 22:03:46 2012
New Revision: 233399
URL: http://svn.freebsd.org/changeset/base/233399

Log:
  MFC r230155:
  	Make man page wording more clear
  
  PR:		docs/164078
  Approved by:	cperciva (implicit)

Modified:
  stable/9/lib/libc/sys/setuid.2
Directory Properties:
  stable/9/lib/libc/   (props changed)
  stable/9/lib/libc/sys/   (props changed)

Modified: stable/9/lib/libc/sys/setuid.2
==============================================================================
--- stable/9/lib/libc/sys/setuid.2	Fri Mar 23 21:19:07 2012	(r233398)
+++ stable/9/lib/libc/sys/setuid.2	Fri Mar 23 22:03:46 2012	(r233399)
@@ -170,7 +170,7 @@ potentially sensitive data.
 .Pp
 To prevent these files from remaining open after an
 .Xr exec 3
-call, be sure to set the close-on-exec flag is set:
+call, be sure to set the close-on-exec flag:
 .Bd -literal
 void
 pseudocode(void)
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

Comment 5 Eitan Adler freebsd_committer

2012-03-23 22:04:07 UTC

State Changed
From-To: patched->closed

Committed. Thanks!