Bug 164423

Summary: [bsd.port.mk] [patch] Pass MAKE_ENV to recursive make invocations
Product: Ports & Packages Reporter: Greg Larkin <glarkin>
Component: Ports FrameworkAssignee: Port Management Team <portmgr>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: arrowd
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
bsd.port.mk.recursive-make-env.diff
none
bsd.port.mk.diff
none
bsd.port.mk.diff.sig none

Description Greg Larkin freebsd_committer freebsd_triage 2012-01-23 21:30:12 UTC 
bsd.port.mk contains several targets that recursively invoke make. If
the top-level make was invoked with a user-specified MAKE_ENV, it is not
passed to the recursive invocations.

Fix: The attached patch invokes recursive make processes with the environment
specified by the top-level MAKE_ENV variable.
How-To-Repeat: In order to configure a port and store the options file
in a non-standard location, the config target can be invoked like so:

    cd /usr/ports/devel/git && \
        make PORT_DBDIR=/tmp config

The options file /tmp/git/options will be created in this example.  If
the port is configured recursively, both of the following commands place
the options files in the standard /var/db/ports location:

    cd /usr/ports/devel/git && \
        make PORT_DBDIR=/tmp config-recursive

    cd /usr/ports/devel/git && \
        make MAKE_ENV+="PORT_DBDIR=/tmp" config-recursive
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-23 21:30:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool)
Comment 2 Greg Larkin freebsd_committer freebsd_triage 2012-11-02 14:58:06 UTC 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I have attached an updated version of the patch that applies to the
current version of Mk/bsd.port.mk, as of Nov 2nd, 2012.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Darwin)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlCT330ACgkQ0sRouByUApD4+QCgoq7+dI8xApA7+XNX4CtTvShw
CUwAoId/TtwsD7xNh/LpOb+vLGo6bP1N
=w4Qr
-----END PGP SIGNATURE-----
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2014-06-02 02:53:54 UTC 
Infrastructure PR.
Comment 4 Gleb Popov freebsd_committer freebsd_triage 2019-08-01 11:06:08 UTC 
If this is still relevant, I'm happy to refresh patches.
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2019-08-01 11:50:40 UTC 
I don't think it's relevant.