Bug 164639

Comment 1 Edwin Groothuis 2012-01-30 16:00:30 UTC

Maintainer of multimedia/mplayer,

Please note that PR ports/164639 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164639

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org

Comment 2 Edwin Groothuis 2012-01-30 16:00:34 UTC

State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

As I am always reluctant to introduce new dependencies...can you
elaborate on the use case that you absolutely _need_ enca for?

well, for russian language we have about 6 different charsets, 
including, but not limited to koi8-r, utf-8, cp1251... and somehow 
subtitles even for different parts for the same video are in different 
charsets, so, it is veru useful to set, e.g.

subcp=enca:ru:utf-8

in ~/.mplayer/config

than guess what charset should I use this time, and set subcp each time 
accordingly, moreover, while I can almost certainly say what charset is 
used in a particular subtitle, sometimes even I wonder what should I use 
for subcp ;)

Shortly, this dependency will ease use of mplayer for languages with 
different charsets.

-- 
SY, Marat

Okay, I get it. You got some valid points (that I now understand, thanks!).
Good, so we can include enca in mplayer, no objections.
I took the liberty to slightly modify your patch, just two minor things:
- Disable enca for mencoder only.
- Remove the explicit --enable-enca configure option. The configure
script should detect its presence on the system and just use it. Would
you verify?

Thomas Zander wrote:
> Okay, I get it. You got some valid points (that I now understand, thanks!).
> Good, so we can include enca in mplayer, no objections.
> I took the liberty to slightly modify your patch, just two minor things:
> - Disable enca for mencoder only.
> - Remove the explicit --enable-enca configure option. The configure
> script should detect its presence on the system and just use it. Would
> you verify?


there's something broken in enca autodetection in latest mplayer :( so, 
configure doesn't detect enca even if it's installed:

% pkg_info -aE | grep enca
enca-1.13

% grep ENCA /var/db/ports/mplayer/options
WITH_ENCA=true

and while trying to make configure:

Script started on Thu Feb  2 22:44:55 2012
make configure
=> SHA256 Checksum OK for mplayer-1.0rc20111218.tar.xz.
...
===>   mplayer-1.0.r20111218_2 depends on shared library: enca.5 - found
...
Checking for SSA/ASS support ... yes
Checking for ENCA ... no
Checking for zlib ... yes
...
Creating config.mak
Creating config.h

Config files successfully generated by ./configure --cc=cc --host-cc=cc 
--as=as --extra-cflags=-I/usr/local/include -I/usr/local/include 
--extra-libs=-L/usr/local/lib --disable-bitmap-font --disable-liba52 
--disable-alsa --enable-ass-internal --disable-enca --disable-directfb 
--disable-faac --disable-faad --disable-libdca --disable-twolame 
--disable-x264 --disable-xvid --disable-libdirac-lavc --disable-mencoder 
--disable-mpg123 --disable-enca --disable-musepack 
--enable-runtime-cpudetection --disable-ssse3 --disable-fast-cmov 
--disable-mad --disable-libdv --disable-speex --disable-jack 
--disable-nas --disable-openal --disable-pulse --disable-bluray 
--disable-smb --disable-fribidi --disable-cdparanoia --disable-libcdio 
--disable-ladspa --disable-liblzo --disable-win32dll --disable-qtx 
--disable-real --disable-libopencore_amrnb --disable-libopencore_amrwb 
--disable-libgsm --disable-tv-v4l1 --disable-tv-v4l2 --disable-librtmp 
--disable-mng --enable-gui --disable-dga1 --disable-dga2 --disable-gl 
--disable-xinerama --enable-xvmc --with-xvmclib=XvMCW --disable-vdpau 
--disable-rtc --disable-arts --disable-caca --disable-lirc --disable-sdl 
--disable-svga --disable-aa --disable-esd --disable-joystick 
--x-libraries=/usr/local/lib --x-includes=/usr/local/include 
--prefix=/usr/local --mandir=/usr/local/man 
--build=amd64-portbld-freebsd8.2 !

   Install prefix: /usr/local
   Data directory: /usr/local/share/mplayer
   Config direct.: /usr/local/etc/mplayer
...
Script done on Thu Feb  2 22:45:25 2012

config.log for enca:

============ Checking for ENCA ============
Result is: no
##########################################

so I forced to use --enable-enca to bypass autodetection failure.

as far as mencoder concerned I have no objections.

-- 
SY, Marat

2012/2/2 Marat N.Afanasyev <amarat@ksu.ru>:

> there's something broken in enca autodetection in latest mplayer :( so,
> configure doesn't detect enca even if it's installed:

I hate when that happens :-(
But besides, there are two --disable-enca arguments to configure. Number one:

> ...
> --disable-alsa --enable-ass-internal --disable-enca --disable-directfb

Number two:

> ...
> --disable-mpg123 --disable-enca --disable-musepack

I'd expect that this causes a problem even if the autodetection did work.
I'll double-check asap.

@Committer: Please don't commit yet, I have to revisit that patch again.

New version of the patch is attached:
- Turn off enca for mencoder
- Allow autodetection of enca for mplayer in mplayer (now works fine here)
- Manually enforce link to v4l libraries (user reported this problem
via personal mail), should allow video 4 linux again
- Bump PORTREVISION for mplayer only (patch does not change behaviour
of mencoder)

Thomas Zander wrote:
> New version of the patch is attached:
> - Turn off enca for mencoder
> - Allow autodetection of enca for mplayer in mplayer (now works fine here)
> - Manually enforce link to v4l libraries (user reported this problem
> via personal mail), should allow video 4 linux again
> - Bump PORTREVISION for mplayer only (patch does not change behaviour
> of mencoder)

Do you want me to run a test? ;)

-- 
SY, Marat

2012/2/6 Marat N.Afanasyev <amarat@ksu.ru>:

> Do you want me to run a test? ;)

If you want to...
Would certainly be helpful if the reporter of this bug confirms that
the latest patch works, so a committer can do his magic :-)

Thomas Zander wrote:
> 2012/2/6 Marat N.Afanasyev<amarat@ksu.ru>:
>
>> Do you want me to run a test? ;)
>
> If you want to...
> Would certainly be helpful if the reporter of this bug confirms that
> the latest patch works, so a committer can do his magic :-)


everything seems to be all right to me.

-- 
SY, Marat

2012/2/7 Marat N.Afanasyev <amarat@ksu.ru>:

> everything seems to be all right to me.

Good!


@Committer: Please commit :-)

Comment 13 Dmitry Marakasov 2012-02-10 14:54:49 UTC

Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.

Comment 14 Dmitry Marakasov 2012-02-10 16:33:46 UTC

State Changed
From-To: feedback->open

Maintainer has approved.

Comment 15 dfilter service 2012-02-10 23:26:41 UTC

amdmi3      2012-02-10 23:26:29 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mplayer   Makefile Makefile.options Makefile.shared 
    multimedia/mencoder  Makefile 
  Log:
  - Add option for enca charset detection
  - Fix v4l support
  
  PR:             164639
  Submitted by:   "Marat N.Afanasyev" <amarat@ksu.ru>
  Fix by:         Thomas Zander <thomas.e.zander@googlemail.com> (maintainer)
  
  Revision  Changes    Path
  1.36      +1 -0      ports/multimedia/mencoder/Makefile
  1.214     +8 -1      ports/multimedia/mplayer/Makefile
  1.26      +3 -1      ports/multimedia/mplayer/Makefile.options
  1.16      +2 -3      ports/multimedia/mplayer/Makefile.shared
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 16 Dmitry Marakasov 2012-02-10 23:26:51 UTC

State Changed
From-To: open->closed

Committed. Thanks!