Bug 164662

Summary: databases/postgresql91-contrib: Configuration introduced overwrites postgresql91-server|client
Product: Ports & Packages Reporter: neil
Component: Individual Port(s)Assignee: Chris Rees <crees>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description neil 2012-01-31 11:00:32 UTC 
The ossp-uuid option introduced into postgresql-contrib-9.1.2_3 overwrites options set through postgresql-server-9.1.2_3.

Fix: 

Can't the postgresql-contrib option be moved into postgresql91-server/Makefile?

Wouldn't the use of ossp-uuid need to be global throughout postgresql91-* builds anyway?
How-To-Repeat: 1) make -C /usr/ports/databases/postgresql91-server config
2) Close options dialog with Save
3) Observe options correctly set in /var/db/ports/postgresql91/options
4) make -C /usr/ports/databases/postgresql91-contrib config
5) Close options dialog with Save
6) Observe server options overwritten in /var/db/ports/postgresql91/options
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2012-01-31 14:42:15 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->crees

update synopsis and assign
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-01-31 18:21:46 UTC 
crees       2012-01-31 18:21:33 UTC

  FreeBSD ports repository

  Modified files:
    databases/postgresql91-contrib Makefile 
    databases/postgresql91-server Makefile 
  Log:
  - Stop clobbering postgresql-server/-client OPTIONS with -contrib OPTIONS
  - Minor optimisation (stop testing for !SLAVE_ONLY twice)
  
  PR:             ports/164662
  
  Revision  Changes    Path
  1.5       +0 -2      ports/databases/postgresql91-contrib/Makefile
  1.242     +5 -4      ports/databases/postgresql91-server/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Chris Rees freebsd_committer freebsd_triage 2012-01-31 18:22:39 UTC 
State Changed
From-To: open->closed

Thanks for reporting.  I've fixed this by giving -contrib a different 
UNIQUENAME from -server and -client; the other two share options where 
-contrib does not.
Comment 4 neil 2012-02-01 10:39:50 UTC 
The UNIQUENAME construction isn't quite correct.

PKGNAMESUFFIX is -contrib and UNIQUENAME is created with 
${...}-${PKGNAMESUFFIX}.

This leads to the creation of /var/db/ports/postgresql91--contrib instead of 
/var/db/ports/postgresql91-contrib.

That is, two hyphens instead of one.