Bug 164906
| Summary: | [PATCH] graphics/libjpeg-turbo: add -fPIC | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | martin.dieringer | ||||
| Component: | Individual Port(s) | Assignee: | Chris Rees <crees> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | bytestore | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
martin.dieringer
2012-02-08 12:30:11 UTC
Maintainer of graphics/libjpeg-turbo,
Please note that PR ports/164906 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164906
--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Yep, i have tested position independent code. Approve it! 08.02.2012, 16:30, "Edwin Groothuis" <edwin@FreeBSD.org>: > Maintainer of graphics/libjpeg-turbo, > > Please note that PR ports/164906 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164906 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org -- ICQ161330462 State Changed From-To: feedback->open Maintainer approved Responsible Changed From-To: freebsd-ports-bugs->crees I'll take it. crees 2012-02-16 08:57:39 UTC
FreeBSD ports repository
Modified files:
graphics/libjpeg-turbo Makefile
Log:
Add -fPIC
PR: ports/164906
Submitted by: Martin Dieringer <martin.dieringer@gmx.de>
Approved by: Denis Podolskiy <bytestore@yandex.ru> (maintainer)
Revision Changes Path
1.16 +2 -2 ports/graphics/libjpeg-turbo/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks! State Changed From-To: closed->open Unfortunately, this appears to be an incomplete solution. We should only be adding -fPIC for shlibs to ensure performance isn't hurt. I'll investigate. crees 2012-03-04 10:02:52 UTC
FreeBSD ports repository
Modified files:
graphics/libjpeg-turbo Makefile
Log:
Revert -fPIC addition; no-op anyway, and uses invalid sh code.
PIC is already detected by libtool.
PR: ports/164906
Submitted by: Jan Beich, bf
Approved by: maintainer timeout
Revision Changes Path
1.17 +2 -2 ports/graphics/libjpeg-turbo/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Reverted-- libtool detects PIC anyway. State Changed From-To: closed->open One more try :) The patch at http://www.bayofrum.net/~crees/patches/jpeg-turbo-fpic.diff adds an OPTION for compiling with PIC; for performance reasons it's probably not best built that way by default. Perhaps check with upstream? State Changed From-To: open->feedback Ask for maintainer approval. Please add this patch using OPTION for someone could need this in the future. -- bytestore@yandex.ru Denis E Podolskiy icq161330462 State Changed From-To: feedback->closed Committed. Thanks! crees 2012-03-14 18:18:40 UTC
FreeBSD ports repository
Modified files:
graphics/libjpeg-turbo Makefile
Log:
Add OPTION for --with-pic
PR: ports/164906
Submitted by: Martin Dieringer <martin.dieringer@gmx.de>
Approved by: bytestore@yandex.ru (maintainer)
Feature safe: yes
Revision Changes Path
1.19 +8 -0 ports/graphics/libjpeg-turbo/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
