Bug 164921

Summary: [PATCH] [MAINTAINER] update to x11-wm/scrotwm
Product: Ports & Packages Reporter: Niclas Zeising <zeising>
Component: Individual Port(s)Assignee: Jason Helfman <jgh>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
x11-wm.scrotwm.update.0.11.0.diff
none
patch.txt
none
patch.txt none

Description Niclas Zeising 2012-02-09 00:20:08 UTC 
	The attached patch updates x11-wm/scrotwm to the latest version.
	Amongst other things it adds UTF-8 support, makes switching between windows easier, and contains a load of bug fixes and fixes for memory and file descriptor leaks.
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2012-02-09 07:06:58 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jgh

I'll take it.
Comment 2 Jason Helfman freebsd_committer freebsd_triage 2012-02-09 18:50:04 UTC 
Can you please consider the following alternative update? I adjusted a
couple of things.

Here are the build logs:
http://redports.org/buildarchive/20120209194057-61715/

Thanks,
Jason

-- 
Jason Helfman         | FreeBSD Committer
jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
Comment 3 Niclas Zeising 2012-02-09 19:35:26 UTC 
The changes to the plist in your patch seems wrong, unless adding things
to PORTEXAMPLES automagically makes it part of the plist. The same goes
for the @dirrm %%EXAMPLESDIR%%. But I might be missing something...
Regards!
-- 
Niclas
Comment 4 Jason Helfman freebsd_committer freebsd_triage 2012-02-09 21:23:34 UTC 
On Thu, Feb 9, 2012 at 11:35 AM, Niclas Zeising <zeising@daemonic.se> wrote:

> The changes to the plist in your patch seems wrong, unless adding things
> to PORTEXAMPLES automagically makes it part of the plist. The same goes
> for the @dirrm %%EXAMPLESDIR%%. But I might be missing something...
> Regards!
> --
> Niclas
>
> Yes, it is automatically added to the packaging list. Beyond this, the
clean build logs indicate proper addition of files/directories, and
clean-up.

Thanks, again.
Jason
Comment 5 Jason Helfman freebsd_committer freebsd_triage 2012-02-10 02:29:16 UTC 
After further review on this, I think it is best to move screenshot.sh to
${PREFIX}/bin based on what it does. Here is a patch for your approval.

Thanks,
Jason

-- 
Jason Helfman         | FreeBSD Committer
jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
Comment 6 Niclas Zeising 2012-02-10 07:54:09 UTC 
Looks good to me.
Thanks for the help! I'm not always aware of all possible tricks :)
Regards!
-- 
Niclas
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-02-10 08:16:42 UTC 
jgh         2012-02-10 08:16:33 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/scrotwm       Makefile distinfo pkg-plist 
  Log:
  - Update to 0.11.0
  - while here cleanup portexamples installation and relocate screeshot.sh to ${PREFIX}/bin
  
  PR: ports/164921
  Submitted by: maintainer, zeising at daemonic.se
  
  Revision  Changes    Path
  1.15      +16 -12    ports/x11-wm/scrotwm/Makefile
  1.13      +2 -2      ports/x11-wm/scrotwm/distinfo
  1.3       +1 -8      ports/x11-wm/scrotwm/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Jason Helfman freebsd_committer freebsd_triage 2012-02-10 08:17:20 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!