Bug 165023

Summary: [patch] devel/p4v port is marked broken and also stale
Product: Ports & Packages Reporter: sweeney
Component: Individual Port(s)Assignee: Gordon Tetlow <gordon>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.shar none

Description sweeney 2012-02-12 06:10:11 UTC 
The P4V port is marked as broken due to invalid distinfo.  The changes in the attached shar file fix it for me.  The 'port test' command successfully builds, installs and removes the port on the environment unamed above.  The 'portlint' command issues two warnings:

[root@dolt] /usr/ports/devel/p4v# portlint
WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them.
0 fatal errors and 2 warnings found.
[root@dolt] /usr/ports/devel/p4v# 

I'm not entirely happy with this, but I couldn't get WRKSRC to function as advertised.  I wasn't able to get the port system to use the appropriate work directory if I set DISTNAME and EXTRACT_SUFX as recommended (and as in the existing port).  I may be overlooking something obvious.  I took the trouble to download all available versions from ftp://ftp.perforce.com/perforce/r10.1/ and verify the checksums and sizes, but I have only been able to test the freebsd70x86_64 version.  From what I can gather from the web site, this may be the final native FreeBSD version of P4V.  I guess we're expected to use the Linux version if we want the newer features.  It might be worth adding some words to the pkg-message to that effect.

Fix: Remove the existing distinfo.* files and apply the attached shar file. 

Patch attached with submission follows:
How-To-Repeat: Try to build the port.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-12 06:10:26 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gordon

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Gordon Tetlow freebsd_committer freebsd_triage 2013-01-23 07:49:56 UTC 
State Changed
From-To: open->closed

Removed port. Perforce has stopped publishing p4v for FreeBSD for a while.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-01-23 07:49:58 UTC 
Author: gordon (src committer)
Date: Wed Jan 23 07:49:45 2013
New Revision: 310856
URL: http://svnweb.freebsd.org/changeset/ports/310856

Log:
  Remove devel/p4v. Perforce stopped making FreeBSD builds about 4 years ago.
  
  PR:		ports/165023

Deleted:
  head/devel/p4v/
Modified:
  head/MOVED
  head/devel/Makefile

Modified: head/MOVED
==============================================================================
--- head/MOVED	Wed Jan 23 07:47:58 2013	(r310855)
+++ head/MOVED	Wed Jan 23 07:49:45 2013	(r310856)
@@ -4005,3 +4005,4 @@ games/py-anki|games/anki|2013-01-16|Proj
 mail/claws-mail-synce||2013-01-16|Has expired: No longer supported by Claws Mail team
 databases/postgresql-plpython|databases/postgresql90-plpython|2013-01-20|This port was splitted out to several versioned ports
 net-mgmt/nfdump-devel||2013-01-22|Has expired: use nfdump instead
+devel/p4v||2013-01-22|No longer publishes FreeBSD version

Modified: head/devel/Makefile
==============================================================================
--- head/devel/Makefile	Wed Jan 23 07:47:58 2013	(r310855)
+++ head/devel/Makefile	Wed Jan 23 07:49:45 2013	(r310856)
@@ -1329,7 +1329,6 @@
     SUBDIR += p4ftpd
     SUBDIR += p4genpatch
     SUBDIR += p4p
-    SUBDIR += p4v
     SUBDIR += p4web
     SUBDIR += p5-AI-Pathfinding-AStar
     SUBDIR += p5-AI-Prolog
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"