Bug 166202

Summary: [patch] editors/vim: respect WITHOUT_NLS
Product: Ports & Packages Reporter: Rachel Flynn <rflynn>
Component: Individual Port(s)Assignee: Chris Rees <crees>
Status: Closed FIXED    
Severity: Affects Only Me CC: obrien
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
vim-nls.patch none

Description Rachel Flynn 2012-03-17 15:40:11 UTC 
When gettext is installed but WITHOUT_NLS flag is set, vim will link with
libintl. Upstream configure however does have the ability to disable NLS
support when requested.

Fix: Side effect of disabling NLS support is that no internationalized manual pages
will be generated.
How-To-Repeat: Set WITHOUT_NLS on command line or through environment, /etc/make.conf and
install vim, while gettext is installed.

Expected: vim does not link with libintl
Actual: vim links with libintl
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-03-17 15:40:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Chris Rees freebsd_committer freebsd_triage 2012-05-27 21:08:40 UTC 
State Changed
From-To: open->feedback

Hi David, is this patch OK?
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-05-28 19:57:20 UTC 
crees       2012-05-28 18:57:07 UTC

  FreeBSD ports repository

  Modified files:
    editors/vim          Makefile 
  Log:
  Respect WITHOUT_NLS properly
  
  PR:             ports/166202
  Submitted by:   Mel Flynn <rflynn@acsalaska.net>
  Approved by:    maintainer timeout (obrien, 6w)
  
  Revision  Changes    Path
  1.390     +5 -2      ports/editors/vim/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Chris Rees freebsd_committer freebsd_triage 2012-05-28 19:57:43 UTC 
State Changed
From-To: feedback->closed

Committed.  Thanks!
Comment 5 Chris Rees freebsd_committer freebsd_triage 2012-05-28 19:57:43 UTC 
Responsible Changed
From-To: obrien->crees

Committed.  Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-05-31 23:00:46 UTC 
crees       2012-05-31 22:00:28 UTC

  FreeBSD ports repository

  Modified files:
    editors/vim          Makefile 
  Log:
  Stop trying to autodetect GETTEXT-- it doesn't work properly anyway and causes
  more problems than it solves.
  
  PR:             ports/168492
  PR:             ports/166202 (a fix for the consequences of)
  Approved by:    maintainer timeout on previous commit that this is to fix,
                  so this is implicit
  
  Revision  Changes    Path
  1.392     +1 -1      ports/editors/vim/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"