Bug 166445

Summary: [PATCH] www/resin3: reorganize rc script
Product: Ports & Packages Reporter: Jason Helfman <jgh>
Component: Individual Port(s)Assignee: Jason Helfman <jgh>
Status: Closed FIXED    
Severity: Affects Only Me CC: bofh
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
resin-3.1.12_1.patch
none
newpatch.txt none

Description Jason Helfman freebsd_committer freebsd_triage 2012-03-27 18:40:08 UTC 
Modifications were requested to the resin rc script from dougb@
I am putting this pr in for approval and review

Added file(s):
- files/resin3.in

Removed file(s):
- files/resin3.sh.in

Port maintainer (5u623l20@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99_5 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-03-27 18:40:17 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jgh

jgh@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-03-27 18:40:20 UTC 
Maintainer of www/resin3,

Please note that PR ports/166445 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166445

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-03-27 18:40:22 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2012-03-27 19:10:58 UTC 
Hi Jason,

Good to see you again. :D

As far as I remember we got rid off the users problem running the
application with www user and group. In that case don't you think we can
get rid off the following variables from the rc file :

+%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"}
+%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"}

Let me know your opinion please.

Regards,
Muhammad
Comment 5 Jason Helfman freebsd_committer freebsd_triage 2012-03-27 19:18:59 UTC 
On Wed, Mar 28, 2012 at 12:10:58AM +0600, Muhammad Moinur Rahman thus spake:
>Hi Jason,
>
>Good to see you again. :D

Good to see you too :)

>
>As far as I remember we got rid off the users problem running the
>application with www user and group. In that case don't you think we can
>get rid off the following variables from the rc file :
>
>+%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"}
>+%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"}
>
>Let me know your opinion please.
>
>Regards,
>Muhammad

We didn't get rid of the USERS/GROUPS usage, though. We are using both
of these, but using the www user and www group.

Since it isn't configurable now, though, you have a a point, so it should at
least be non-configurable in the rc script.

Included is an updated patch.

-jgh

-- 
Jason Helfman         | FreeBSD Committer
jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2012-03-28 02:42:24 UTC 
State Changed
From-To: feedback->feedback

Add misfiled PRs to Audit-Trail.
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2012-03-28 02:42:24 UTC 
Responsible Changed
From-To: jgh->jgh
Comment 8 Mark Linimon freebsd_committer freebsd_triage 2012-03-28 06:54:43 UTC 
State Changed
From-To: feedback->open

From misfiled PR ports/166461: 

Date: Wed, 28 Mar 2012 09:52:11 +0600
Comment 9 Mark Linimon freebsd_committer freebsd_triage 2012-03-28 06:54:43 UTC 
Responsible Changed
From-To: jgh->jgh
Comment 10 dfilter service freebsd_committer freebsd_triage 2012-04-03 00:51:38 UTC 
jgh         2012-04-02 23:51:25 UTC

  FreeBSD ports repository

  Modified files:
    www/resin3           Makefile 
  Added files:
    www/resin3/files     resin3.in 
  Removed files:
    www/resin3/files     resin3.sh.in 
  Log:
  - reorg of rc script based on standards and move from .sh => .in
  - bump PORTREVISION
  
  PR:     ports/166445
  Submitted by:   jgh (me)
  Approved by:    maintainer, 5u623l20@gmail.com
  Feature safe:   yes
  
  Revision  Changes    Path
  1.47      +2 -1      ports/www/resin3/Makefile
  1.1       +43 -0     ports/www/resin3/files/resin3.in (new)
  1.2       +0 -43     ports/www/resin3/files/resin3.sh.in (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 11 Jason Helfman freebsd_committer freebsd_triage 2012-04-03 00:51:44 UTC 
State Changed
From-To: open->closed

Committed. Thanks!