Bug 167382

Summary: geli.8 out of sync after r226840 re: kernel threads
Product: Documentation Reporter: John W. O'Brien <john>
Component: Books & ArticlesAssignee: Glen Barber <gjb>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description John W. O'Brien 2012-04-28 00:10:10 UTC 
r226840 did not update description of affected behavior in geli(8) manpage.

Fix: Strike line stating that only one thread will be started when using hardware crypto acceleration.

Patch attached with submission follows:
How-To-Repeat: man geli
Search for "kern.geom.eli.threads".
Observe that following r226840, number of threads is not limited when, e.g., AESNI instructions are available.
Comment 1 Glen Barber freebsd_committer freebsd_triage 2012-04-28 02:27:06 UTC 
Responsible Changed
From-To: freebsd-doc->gjb

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-04-28 21:23:23 UTC 
Author: gjb (doc committer)
Date: Sat Apr 28 20:23:13 2012
New Revision: 234770
URL: http://svn.freebsd.org/changeset/base/234770

Log:
  As of r226840, GELI starts one thread per CPU.
  
  PR:		167382
  Submitted by:	John W. O'Brien (john%saltant.com)
  X-Needs-MFC:	r226840

Modified:
  head/sbin/geom/class/eli/geli.8

Modified: head/sbin/geom/class/eli/geli.8
==============================================================================
--- head/sbin/geom/class/eli/geli.8	Sat Apr 28 18:57:27 2012	(r234769)
+++ head/sbin/geom/class/eli/geli.8	Sat Apr 28 20:23:13 2012	(r234770)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd March 4, 2012
+.Dd April 28, 2012
 .Dt GELI 8
 .Os
 .Sh NAME
@@ -692,7 +692,6 @@ This variable should be set in
 Specifies how many kernel threads should be used for doing software
 cryptography.
 Its purpose is to increase performance on SMP systems.
-If hardware acceleration is available, only one thread will be started.
 If set to 0, a CPU-pinned thread will be started for every active CPU.
 .It Va kern.geom.eli.batch : No 0
 When set to 1, can speed-up crypto operations by using batching.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Glen Barber freebsd_committer freebsd_triage 2012-04-28 21:38:20 UTC 
State Changed
From-To: open->closed

Committed, thanks!