Bug 167460

Summary: devel/libytnef: bad handling of PT_CLSID in TNEFFillMapi
Product: Ports & Packages Reporter: Sean Bruno <sbruno>
Component: Individual Port(s)Assignee: Thomas Abthorpe <tabthorpe>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Sean Bruno freebsd_committer freebsd_triage 2012-04-30 20:30:09 UTC 
devel/libytnef/ytnef.c has incomplete handling of the PT_CLSID type and will spin off and crash applications attempting to use it.

Patch attached properly handles the GUID data structure via hardcoded magic values.

Fix ideas were liberally stolen from the MSDN docs and wine.org handling code.
Comment 1 seanbru 2012-04-30 20:56:37 UTC 
Patch located at:

http://people.freebsd.org/~sbruno/libytnef_ytnef_c.txt

Sean
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2012-05-01 02:07:52 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

ports PR.
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-01 02:08:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sbruno

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-01 02:08:23 UTC 
Maintainer of devel/libytnef,

Please note that PR ports/167460 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/167460

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 5 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-01 02:08:24 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 6 seanbru 2012-05-07 16:49:02 UTC 
I'm almost 100% positive that this library is dead upstream.

http://ytnef.sourceforge.net/

Last update was 2004-09-14 according to sourceforge.  I think its
completely reasonable to patch our port of this and move on.

Sean
Comment 7 Thomas Abthorpe freebsd_committer freebsd_triage 2012-05-12 04:18:27 UTC 
Responsible Changed
From-To: sbruno->tabthorpe

I'll take it.
Comment 8 dfilter service freebsd_committer freebsd_triage 2012-05-28 20:28:47 UTC 
tabthorpe    2012-05-28 19:28:38 UTC

  FreeBSD ports repository

  Modified files:
    devel/libytnef       Makefile 
  Added files:
    devel/libytnef/files patch-ytnef.c 
  Log:
  - Fix handling of T_CLSID in TNEFFillMapi
  - Bump PORTREVISION
  
  PR:             ports/167460
  Submitted by:   sbruno@
  Approved by:    maintainer timeout
  
  Revision  Changes    Path
  1.9       +1 -1      ports/devel/libytnef/Makefile
  1.1       +25 -0     ports/devel/libytnef/files/patch-ytnef.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Thomas Abthorpe freebsd_committer freebsd_triage 2012-05-28 20:29:05 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!