Bug 167482

As of security/tor-devel 0.2.3.9.a, additional log files specified in
torrc are overridden by the default rc script, due to a syntax change
made upstream. Quoting the ChangeLog:

| Changes in version 0.2.3.9-alpha - 2011-12-08
| [...]
| o Minor features (new/different config options):
| [...]
|    - Slightly change behavior of "list" options (that is, config
|      options that can appear more than once) when they appear both in
|      torrc and on the command line. Previously, the command-line options
|      would be appended to the ones from torrc. Now, the command-line
|      options override the torrc options entirely. This new behavior
|      allows the user to override list options (like exit policies and
|      ports to listen on) from the command line, rather than simply
|      appending to the list.
|    - You can get the old (appending) command-line behavior for "list"
|      options by prefixing the option name with a "+".

Fix: The attached patch adds the "+" to the list option, thus getting the previous behavior again.

The alternative would be to remove the --Log option completely, forcing the user to specify all log files in the torrc. As a user with multiple log files I would prefer that, but users with a single log file probably wouldn't.

Patch attached with submission follows:
How-To-Repeat: Add a line like the following to /usr/local/etc/tor/torrc:
Log [app]debug info file /usr/local/var/log/tor/debug.log
restart tor, note that tor doesn't write to the file.