Bug 168240

Summary: [patch] graphics/zathura{,-pdf-poppler}: move poppler-glib dep to pdf plugin
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Pawel Pekala <pawel>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
poppler.diff none

Description Jan Beich freebsd_committer freebsd_triage 2012-05-22 22:10:04 UTC 
Main zathura port has no dependency on poppler.

How-To-Repeat: $ cd graphics/zathura; make patch
$ fgrep -ir poppler $(make -V WRKSRC)/
Exit 1

$ cd graphics/zathura-pdf-poppler; make patch
$ fgrep -irh --exclude \*.orig pkg-config.\*poppler $(make -V WRKSRC)/
PDF_INC ?= $(shell pkg-config --cflags poppler-glib)
PDF_LIB ?= $(shell pkg-config --libs poppler-glib)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-22 22:10:16 UTC 
Maintainer of graphics/zathura,

Please note that PR ports/168240 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168240

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-22 22:10:18 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2012-05-23 01:02:45 UTC 
Jan Beich <jbeich@tormail.org> writes:

> -LIB_DEPENDS=	poppler.18:${PORTSDIR}/graphics/poppler
> +LIB_DEPENDS=	poppler-glib.8:${PORTSDIR}/graphics/poppler
                                                   ^^^^^^^^^^
Oops, it should be graphics/poppler-glib of course.
Comment 4 quentin.stievenart 2012-05-23 08:00:43 UTC 
Patch approved.
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2012-05-23 08:12:02 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 6 Pawel Pekala freebsd_committer freebsd_triage 2012-05-23 15:06:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 7 Pawel Pekala freebsd_committer freebsd_triage 2012-05-23 22:35:52 UTC 
State Changed
From-To: open->closed

Committed. Thanks!