Summary: | deskutils/xfce4-notification-daemon broken (several versions) | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | freebsd |
Component: | Individual Port(s) | Assignee: | Emanuel Haupt <ehaupt> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | ||
Priority: | Normal | ||
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
freebsd
2012-05-27 00:30:06 UTC
Responsible Changed From-To: freebsd-ports-bugs->ehaupt Over to maintainer (via the GNATS Auto Assign Tool) I was just able to build it on 9.0 amd64: http://people.freebsd.org/~ehaupt/buildlogs/xfce4-notification-daemon-0.3.7_15.log Since your ports are all up to date my guess would be that you might have old conflicting shared libraries installed. You could try (requires: sysutils/bsdadminscripts, ports-mgmt/portmaster): $ portmaster -y --check-depends $ portmaster -y --check-port-dbdir $ mv /usr/local/lib/compat/pkg /usr/local/lib/compat/pkg.orig $ /etc/rc.d/ldconfig restart $ pkg_libchk sysutils/bsdadminscripts ports-mgmt/portmaster - rebuild all ports with missing libraries - retry building deskutils/xfce4-notification-daemon On 05/29/12 09:26, Emanuel Haupt wrote: > I was just able to build it on 9.0 amd64: > http://people.freebsd.org/~ehaupt/buildlogs/xfce4-notification-daemon-0.3.7_15.log > > Since your ports are all up to date my guess would be that you might > have old conflicting shared libraries installed. > > You could try (requires: sysutils/bsdadminscripts, ports-mgmt/portmaster): > > $ portmaster -y --check-depends > $ portmaster -y --check-port-dbdir > $ mv /usr/local/lib/compat/pkg /usr/local/lib/compat/pkg.orig > $ /etc/rc.d/ldconfig restart > $ pkg_libchk > > sysutils/bsdadminscripts > ports-mgmt/portmaster > > - rebuild all ports with missing libraries > - retry building deskutils/xfce4-notification-daemon Did all that, resolved a couple of 'old library issues' until pkg_libchk returned a clean bil of health. Removed /usr/local/lib/compat/ entirely and re-ran 'ldconfig restart'. Removed /etc/make.conf to rule out any settings in there. Same problem, exact same place. Diff'ed my output against yours, and found nothing interesting. I included one more path (-I/usr/local/lib/gtk-2.0/include) that you didn't, but that was really all. Is the very specific place where it keeps failing any hint at all? main.c: In function 'notification_settings_preview': main.c:191: error: too many arguments to function 'notify_notification_new' ---- Making all in settings gmake[3]: Entering directory `/usr/ports/deskutils/xfce4-notification-daemon/work/notification-daemon-xfce-0.3.7/src/settings' cc -DHAVE_CONFIG_H -I. -I../.. -I../.. -DBINDIR=\"/usr/local/bin\" -DDATADIR=\"/usr/local/share\" -DPACKAGE_LOCALE_DIR=\"/usr/local/share/locale\" -I/usr/local/include -L/usr/local/lib -D_THREAD_SAFE -D_REENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libpng -I/usr/local/include/xfce4 -I/usr/local/include/glib-2.0 -D_THREAD_SAFE -D_REENTRANT -I/usr/local/include -I/usr/local/include/xfce4 -I/usr/local/include/gtk-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libpng -I/usr/local/include/atk-1.0 -I/usr/local/include/dbus-1.0 -I/usr/local/include/dbus-1.0/include -D_REENTRANT -I/usr/local/include/dbus-1.0 -I/usr/local/include/dbus-1.0/include -I/usr/local/include/glib-2.0 -D_REENTRANT -I/usr/local/include -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/glib-2.0 -I/usr/local/include/libpng -O2 -pipe -fno-strict-aliasing -MT notification_settings-main.o -MD -MP -MF .deps/notification_settings-main.Tpo -c -o notification_settings-main.o `test -f 'main.c' || echo './'`main.c LC_ALL=C ../../intltool-merge -d -u -c ../../po/.intltool-merge-cache ../../po notification-settings.desktop.in notification-settings.desktop Generating and caching the translation database Merging translations into notification-settings.desktop. main.c: In function 'notification_settings_preview': main.c:191: error: too many arguments to function 'notify_notification_new' gmake[3]: *** [notification_settings-main.o] Error 1 gmake[3]: Leaving directory `/usr/ports/deskutils/xfce4-notification-daemon/work/notification-daemon-xfce-0.3.7/src/settings' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory `/usr/ports/deskutils/xfce4-notification-daemon/work/notification-daemon-xfce-0.3.7/src' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/ports/deskutils/xfce4-notification-daemon/work/notification-daemon-xfce-0.3.7' gmake: *** [all] Error 2 *** Error code 1 Stop in /usr/ports/deskutils/xfce4-notification-daemon. *** Error code 1 Stop in /usr/ports/deskutils/xfce4-notification-daemon. On 05/29/12 09:26, Emanuel Haupt wrote: > I was just able to build it on 9.0 amd64: > http://people.freebsd.org/~ehaupt/buildlogs/xfce4-notification-daemon-0.3.7_15.log > > Since your ports are all up to date my guess would be that you might > have old conflicting shared libraries installed. > > You could try (requires: sysutils/bsdadminscripts, ports-mgmt/portmaster): > > $ portmaster -y --check-depends > $ portmaster -y --check-port-dbdir > $ mv /usr/local/lib/compat/pkg /usr/local/lib/compat/pkg.orig > $ /etc/rc.d/ldconfig restart > $ pkg_libchk > > sysutils/bsdadminscripts > ports-mgmt/portmaster > > - rebuild all ports with missing libraries > - retry building deskutils/xfce4-notification-daemon Note: after deleteing the xfce-notification package and removing all dependencies and dependecy options associated with it I did a final rebuild, re-installing all dependencies again, with default options. Result: Generating and caching the translation database Merging translations into notification-settings.desktop. main.c: In function 'notification_settings_preview': main.c:191: error: too many arguments to function 'notify_notification_new' gmake[3]: *** [notification_settings-main.o] Error 1 gmake[3]: Leaving directory `/staging/usr/ports/deskutils/xfce4-notification-daemon/work/notification-daemon-xfce-0.3.7/src/settings' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory `/staging/usr/ports/deskutils/xfce4-notification-daemon/work/notification-daemon-xfce-0.3.7/src' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/staging/usr/ports/deskutils/xfce4-notification-daemon/work/notification-daemon-xfce-0.3.7' gmake: *** [all] Error 2 *** Error code 1 Stop in /usr/ports/deskutils/xfce4-notification-daemon. *** Error code 1 Stop in /usr/ports/deskutils/xfce4-notification-daemon. ===>>> make failed for deskutils/xfce4-notification-daemon ===>>> Aborting update Terminated ===>>> The following actions were performed: Installation of devel/libtool (libtool-2.4.2) Installation of textproc/libcroco (libcroco-0.6.2_1) Installation of x11-themes/gtk-engines2 (gtk-engines2-2.20.2) Installation of graphics/librsvg2 (librsvg2-2.34.1) Installation of misc/iso-codes (iso-codes-3.35) Installation of x11-toolkits/libsexy (libsexy-0.1.11_5) ===>>> Deleting installed build-only dependencies ===>>> You can restart from the point of failure with this command line: portmaster <flags> deskutils/xfce4-notification-daemon ----- So, still no cigar. Could you please try the following patch: --- patch begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/deskutils/xfce4-notification-daemon/Makefile,v retrieving revision 1.25 diff -u -r1.25 Makefile --- Makefile 25 May 2012 16:52:29 -0000 1.25 +++ Makefile 29 May 2012 13:14:44 -0000 @@ -7,7 +7,7 @@ PORTNAME= notification-daemon PORTVERSION= 0.3.7 -PORTREVISION= 15 +PORTREVISION= 16 CATEGORIES= deskutils xfce MASTER_SITES= CRITICAL/ PKGNAMEPREFIX= xfce4- Index: files/patch-src__settings__main.c =================================================================== RCS file: files/patch-src__settings__main.c diff -N files/patch-src__settings__main.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/patch-src__settings__main.c 29 May 2012 13:14:44 -0000 @@ -0,0 +1,12 @@ +--- ./src/settings/main.c.orig 2012-05-29 15:07:41.000000000 +0200 ++++ ./src/settings/main.c 2012-05-29 15:08:08.000000000 +0200 +@@ -187,8 +187,7 @@ + /* create new preview notification */ + preview = notify_notification_new (_("Preview notification"), + _("Lorem Ipsum is simply dummy text of the printing and typesetting industry."), +- "notification-settings", +- NULL); ++ "notification-settings"); + + notify_notification_set_urgency (preview, NOTIFY_URGENCY_NORMAL); + notify_notification_set_category(preview, "preview"); --- patch ends here --- That works, thanks. I'll leave it up to you whether this is a patch that should be incorporated into the port itself ;) On 05/29/12 15:12, Emanuel Haupt wrote: > Could you please try the following patch: > > --- patch begins here --- > Index: Makefile > =================================================================== > RCS file: /home/pcvs/ports/deskutils/xfce4-notification-daemon/Makefile,v > retrieving revision 1.25 > diff -u -r1.25 Makefile > --- Makefile 25 May 2012 16:52:29 -0000 1.25 > +++ Makefile 29 May 2012 13:14:44 -0000 > @@ -7,7 +7,7 @@ > > PORTNAME= notification-daemon > PORTVERSION= 0.3.7 > -PORTREVISION= 15 > +PORTREVISION= 16 > CATEGORIES= deskutils xfce > MASTER_SITES= CRITICAL/ > PKGNAMEPREFIX= xfce4- > Index: files/patch-src__settings__main.c > =================================================================== > RCS file: files/patch-src__settings__main.c > diff -N files/patch-src__settings__main.c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ files/patch-src__settings__main.c 29 May 2012 13:14:44 -0000 > @@ -0,0 +1,12 @@ > +--- ./src/settings/main.c.orig 2012-05-29 15:07:41.000000000 +0200 > ++++ ./src/settings/main.c 2012-05-29 15:08:08.000000000 +0200 > +@@ -187,8 +187,7 @@ > + /* create new preview notification */ > + preview = notify_notification_new (_("Preview notification"), > + _("Lorem Ipsum is simply dummy text of the printing and typesetting industry."), > +- "notification-settings", > +- NULL); > ++ "notification-settings"); > + > + notify_notification_set_urgency (preview, NOTIFY_URGENCY_NORMAL); > + notify_notification_set_category(preview, "preview"); > --- patch ends here --- "Ben C. O. Grimm" <freebsd@bengrimm.net> wrote: > That works, thanks. I'll leave it up to you whether this is a patch > that should be incorporated into the port itself ;) Perfect! Looks like libnotify changed the API and your compiler was more picky than mine. Just out of curiosity. Which gcc version are you using (gcc -v)? Are you using any custom CFLAGS? Does 'notify-send' work as expected (it should, since I simply ditched the 4th NULL argument)? If so I'll commit the patch. Emanuel On 05/29/12 16:05, Emanuel Haupt wrote: > "Ben C. O. Grimm"<freebsd@bengrimm.net> wrote: >> That works, thanks. I'll leave it up to you whether this is a patch >> that should be incorporated into the port itself ;) > > Perfect! Looks like libnotify changed the API and your compiler was > more picky than mine. Just out of curiosity. Which gcc version are you > using (gcc -v)? Are you using any custom CFLAGS? > > Does 'notify-send' work as expected (it should, since I simply ditched > the 4th NULL argument)? If so I'll commit the patch. > > Emanuel $ gcc -v Using built-in specs. Target: amd64-undermydesk-freebsd Configured with: FreeBSD/amd64 system compiler Thread model: posix gcc version 4.2.1 20070831 patched [FreeBSD] --- BUT: I also have gcc-4.6.4.20120511 installed, and `pkg_info -R gcc-4.6.4.20120511` does show that libnotify-0.7.3_1 and xfce4-notification-daemon-0.3.7_15 (and others, see below) use it. I'm not quite sure why, because only www/chromium has a requirement (WITH_GCC46=true) in its options set. I'm usually pretty conservative when it comes to overruling the base system compiler, so I'm curious about this widespread dependency on GCC46, to be honest. Maybe some "inherited" option, or even a mandatory compiler for some of the ports. This may of course obviate the need to patch after all ;) Other than that: no CFLAGS at all, error happened with and without a make.conf in place. notify-send prints a pop-up window, as expected. Full output of $ pkg_info -R gcc-4.6.4.20120511 Information for gcc-4.6.4.20120511: Required by: dconf-0.5.1_3 farsight2-0.0.22 filezilla-3.5.3 firefox-12.0,1 gconf2-2.32.0_2 geeqie-1.0_4 gqview-2.0.4_12 gtkspell-2.0.16_3 gvfs-1.6.6_2 icons-buuf-1.6r2_5 icons-tango-0.8.90_1 icons-tango-extras-0.1.0_4 libcanberra-0.28_1 libglade2-2.6.4_4 libgnome-keyring-2.32.0_1 libgsf-1.14.21 libnotify-0.7.3_1 libsoup-gnome-2.34.3_1 libwnck-2.30.6 mbpurple-0.3.0_1 mplayer-1.0.r20120322_1 nspluginwrapper-1.4.4 nvidia-settings-295.40 p5-URI-1.60 putty-0.62 py27-gtk-2.24.0 roxterm-2.2.2 thunderbird-12.0.1 vte-0.26.2_1 wxgtk2-common-2.8.12 wxgtk2-unicode-2.8.12 zenity-2.32.1_1 libpurple-2.10.4 pidgin-2.10.4 pidgin-privacy-please-0.7.1_1 xfce4-tumbler-0.1.25 libexo-0.8.0 xfce4-panel-4.10.0 Thunar-1.4.0 libxfce4gui-4.10.0 thunar-vfs-1.2.0_1 squeeze-0.2.3_3 xfce4-desktop-4.10.0 xfce4-mixer-4.8.0_1 xfce4-session-4.10.0 xfce4-settings-4.10.0 xfce4-wm-4.10.0 xfce-4.10 xfce4-battery-plugin-1.0.4 xfce4-screenshooter-plugin-1.8.0_1 p5-HTTP-Message-6.03_1 p5-HTTP-Cookies-6.01 p5-HTTP-Daemon-6.01 p5-HTTP-Negotiate-6.01 p5-WWW-RobotRules-6.02 p5-libwww-6.04 xscreensaver-5.15 chromium-19.0.1084.52 Terminal-0.4.8 mousepad-0.2.16_9 thunar-media-tags-plugin-0.2.0 xfce4-print-4.6.1_7 librsvg2-2.34.1 xfce4-notification-daemon-0.3.7_15 ehaupt 2012-05-29 14:34:47 UTC FreeBSD ports repository Modified files: deskutils/xfce4-notification-daemon Makefile Added files: deskutils/xfce4-notification-daemon/files patch-src__settings__main.c Log: Provide a patch to chase a libnotify api change. PR: 168355 (based on) Submitted by: Ben Grimm <freebsd@bengrimm.net> Revision Changes Path 1.26 +1 -1 ports/deskutils/xfce4-notification-daemon/Makefile 1.1 +12 -0 ports/deskutils/xfce4-notification-daemon/files/patch-src__settings__main.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" State Changed From-To: open->closed Patch committed, thanks for the bug report. |