Bug 168480

Summary: [bsd.port.mk] OPTIONSNG: make config sanity checking
Product: Ports & Packages Reporter: Bryan Drewery <bryan>
Component: Individual Port(s)Assignee: Martin Wilke <miwi>
Status: Closed FIXED    
Severity: Affects Only Me CC: bapt
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-bsd.port.mk.sanity-config.txt none

Description Bryan Drewery 2012-05-31 02:30:03 UTC
	- Fix 'make check-config' not listing *all* errors
	- Have 'make config' run 'check-config' in a prompted re-edit to prevent build failures later if running 'config/config-conditional' up-front before large batch builds.

	This will cause 'make config' to automatically run 'check-config', but also offer the user to auto re-run 'make config' if the config is still invalid. This assists large batch operations where the user runs 'make config' or 'make config-conditional' for all of their ports up-front, before building them all and finding that the error exists there.

	I am open to removing the prompt and auto re-config. However, fixing 'make check-config' to list all error, and auto running 'make check-config' seem worth having at minimum.
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2012-05-31 03:27:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

take for exprun
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-06-09 13:19:27 UTC
miwi        2012-06-09 12:19:12 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.port.mk 
  Log:
  - Add optionsNG make config sanity check support
  
  PR:             168480
  Submitted by:   "Bryan Drewery" <bryan@shatow.net>
  Reviewed by:    bapt
  
  Revision  Changes    Path
  1.728     +27 -5     ports/Mk/bsd.port.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2012-06-09 13:19:31 UTC
State Changed
From-To: open->closed

Committed. Thanks!