Bug 168707
| Summary: | [maintainer-update] [patch] devel/diffuse: Convert to new options framework | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Marco Bröder <marco.broeder> | ||||
| Component: | Individual Port(s) | Assignee: | Sylvio Cesar Teixeira <sylvio> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-ports-bugs->sylvio I'll take it. State Changed From-To: open->closed Committed. Thanks! sylvio 2012-06-06 20:57:59 UTC
FreeBSD ports repository
Modified files:
devel/diffuse Makefile
Log:
- Convert to new options framework
- Add two additional options and disable automatic sorting
- Add necessary checks for conflicting options vs. make.conf settings
(NOPORTDOCS, NOPORTDATA, WITHOUT_NLS)
- Port passes all tests of all combinations of options, including potentially
conflicting make.conf settings (NOPORTDOCS, NOPORTDATA, WITHOUT_NLS)
- Mark conflict with biology/tinker, both ports install ${PREFIX}/bin/diffuse
- Bump PORTREVISION
PR: ports/168707
Submitted by: Marco Bröder <marco.broeder@gmx.eu> (maintainer)
Revision Changes Path
1.17 +36 -28 ports/devel/diffuse/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
- Convert to new options framework - Add two additional options and disable automatic sorting - Add necessary checks for conflicting options vs. make.conf settings (NOPORTDOCS, NOPORTDATA, WITHOUT_NLS) - Port passes all tests of all combinations of options, including potentially conflicting make.conf settings (NOPORTDOCS, NOPORTDATA, WITHOUT_NLS) - Mark conflict with biology/tinker, both ports install ${PREFIX}/bin/diffuse - Bump PORTREVISION Tested: portlint, several tinderbox runs, pkg_add / pkg_delete, runtime Thanks! PS: NOPORTDATA is not covered by new options framework. It should probably be treated like NOPORTDOCS => DOCS and NOPORTEXAMPLES => EXAMPLES: bsd.options.mk: .if !defined(NOPORTDATA) PORT_OPTIONS+=DATA .endif .if empty(PORT_OPTIONS:MDATA) NOPORTDATA=yes .endif bsd.options.desc.mk: DATA_DESC=Build and install additional or special data files .. or a better description than that. Fix: Patch attached with submission follows: