Bug 168837

Summary: [maintainer-update] games/stonesoup: convert options to optionsNG
Product: Ports & Packages Reporter: Tobias Rehbein <tobias.rehbein>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
games-stonesoup_optionsng.diff
none
stonesoup.diff
none
stonesoup.diff none

Description Tobias Rehbein 2012-06-08 09:20:17 UTC 
	
	Convert makefile options to the new options framework.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2012-06-08 11:15:31 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

I'll take it.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2012-06-10 14:15:57 UTC 
Hi,

I made a small change to your submission to complete the transition.

stonesoup also has a slave port which needs too to use the new options 
framework. Please check the attached patch(relative to ports) which I 
tested to update both.

I'll wait for your approval before committing.

Thanks in advance!

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2012-06-11 10:32:33 UTC 
My mentor suggested a few fixes to my patch, for which I also thank him.

So please ignore my previous patch and check the attached one.

Thank you again.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2012-06-11 12:24:58 UTC 
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 5 Tobias Rehbein 2012-06-12 17:35:18 UTC 
Am Mon, Jun 11, 2012 at 11:32:33AM +0200 schrieb Guido Falsi:
> My mentor suggested a few fixes to my patch, for which I also thank him.
> 
> So please ignore my previous patch and check the attached one.
> 
> Thank you again.

Hi.

Interesting. I thought the direct manipulation of PORT_OPTIONS might be
forbidden. But if the proposed solution is ok, it seems legit to me.

Regards,

	Tobias
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2012-06-12 22:08:59 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-06-12 22:09:05 UTC 
madpilot    2012-06-12 21:08:54 UTC

  FreeBSD ports repository

  Modified files:
    games/stonesoup      Makefile 
    games/stonesoup-sdl  Makefile 
  Log:
  Convert to new options framework.
  
  PR:             ports/168837
  Submitted by:   Tobias Rehbein <tobias.rehbein@web.de> (maintainer)
  Approved by:    crees (mentor)
  
  Revision  Changes    Path
  1.2       +1 -1      ports/games/stonesoup-sdl/Makefile
  1.22      +12 -10    ports/games/stonesoup/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"