Bug 169219

Summary: [PATCH] sysutils/acpi_call: fix usage of ${SRC_BASE} before it is defined
Product: Ports & Packages Reporter: Jason Helfman <jgh>
Component: Individual Port(s)Assignee: Jason Helfman <jgh>
Status: Closed FIXED    
Severity: Affects Only Me CC: gelraen.ua
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
acpi_call-1.0.1.patch none

Description Jason Helfman freebsd_committer freebsd_triage 2012-06-19 00:40:21 UTC
Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

Port maintainer (gelraen.ua@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-19 00:41:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-19 00:41:21 UTC
Maintainer of sysutils/acpi_call,

Please note that PR ports/169219 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169219

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-19 00:41:24 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 gelraen.ua 2012-06-23 12:39:21 UTC
Looks fine. Thanks.
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-06-23 20:17:32 UTC
jgh         2012-06-23 19:17:23 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/acpi_call   Makefile 
  Log:
  - re-order, include bsd.port.pre.mk so SRC_BASE is defined before referenced
  
  PR:     ports/169219
  Submitted by:   jgh@
  Approved by:    maintainer, gelraen.ua@gmail.com
  
  Revision  Changes    Path
  1.6       +3 -1      ports/sysutils/acpi_call/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Jason Helfman freebsd_committer freebsd_triage 2012-06-23 20:17:51 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!