Bug 16926

Summary: [PATCH] banner doesn't allocate space for nul
Product: Base System Reporter: spock <spock>
Component: binAssignee: Mike Heffner <mikeh>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description spock 2000-02-23 06:10:00 UTC 
Banner doesn't allocate enough memory for the nul character. Banner 
will seg fault if it's sent a string with any multiple of 4096 
characters, because the nul ends up being written onto an unmapped 
page. This patch was posted to -audit a few weeks ago.

Fix: apply the following patch and recompile.
How-To-Repeat: run banner with a multiple of 4096 character string
Ex: banner [4096]
Comment 1 Kris Kennaway freebsd_committer freebsd_triage 2000-03-04 06:23:41 UTC 
Responsible Changed
From-To: freebsd-bugs->kris

My bug, I'll fix :) Sorry for not responding to your mail..
Comment 2 Mike Heffner freebsd_committer freebsd_triage 2001-05-28 05:00:51 UTC 
Responsible Changed
From-To: kris->mikeh

I just committed the fix for this.
Comment 3 Mike Heffner freebsd_committer freebsd_triage 2001-06-14 01:08:04 UTC 
State Changed
From-To: open->closed

Fix has been MFCed.