Bug 170007

Summary: [PATCH] dns/unbound Incorrect use of empty()
Product: Ports & Packages Reporter: Chris Rees <crees>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch.txt none

Description Chris Rees 2012-07-19 22:10:11 UTC
	.if empty() in a Makefile should not have a $ in;

	correct:
	.if empty(FOO)

	incorrect:
	.if empty(${FOO})

Fix: Submitted by Alexey Kouznetsov
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-07-19 22:10:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sem

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2012-07-21 21:41:14 UTC
State Changed
From-To: open->		 closed

Committed. Thanks! 


Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2012-07-21 21:41:14 UTC
Responsible Changed
From-To: sem->sunpoet

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-07-21 21:41:22 UTC
Author: sunpoet
Date: Sat Jul 21 20:41:09 2012
New Revision: 301286
URL: http://svn.freebsd.org/changeset/ports/301286

Log:
  - Fix option handling of THREADS
  
  PR:		ports/170007
  Reported by:	Alexey Kouznetsov <alexey@kouznetsov.com>
  Submitted by:	crees
  Approved by:	sem (maintainer)

Modified:
  head/dns/unbound/Makefile   (contents, props changed)

Modified: head/dns/unbound/Makefile
==============================================================================
--- head/dns/unbound/Makefile	Sat Jul 21 20:02:06 2012	(r301285)
+++ head/dns/unbound/Makefile	Sat Jul 21 20:41:09 2012	(r301286)
@@ -88,7 +88,7 @@ CONFIGURE_ARGS+=--with-libevent=${LOCALB
 CONFIGURE_ARGS+=--with-libevent=no
 .endif
 
-.if empty(${PORT_OPTIONS:MTHREADS})
+.if empty(PORT_OPTIONS:MTHREADS)
 CONFIGURE_ARGS+=--without-pthreads
 .endif
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"