Bug 170400
| Summary: | [PATCH] lang/php5-extensions: Add pdo_mysql and pdo_pgsql | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bryan Drewery <bdrewery> | ||||
| Component: | Individual Port(s) | Assignee: | Alex Dupre <ale> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Bryan Drewery
2012-08-06 02:40:01 UTC
Responsible Changed From-To: freebsd-ports-bugs->ale Over to maintainer (via the GNATS Auto Assign Tool) State Changed From-To: open->feedback Motivation? ports/149942 added PDO_MYSQL to php52-extensions in 2010. Personally at some point I had selected that in php52, and then deinstalled/reinstalled php5 (when 5.3) and lost the extension. I was surprised by a user asking for it to be installed. It's a bit confusing to have PDO listed here as a user may assume that just because they select PDO it will work in common cases. But they'll likely need the pdo_mysql or pdo_pgsql extension as well. I have filed ports/170401 for lang/php53-extensions as well. -- Regards, Bryan Drewery bdrewery@freenode/EFNet Bryan Drewery ha scritto:
> ports/149942 added PDO_MYSQL to php52-extensions in 2010. Personally at
> some point I had selected that in php52, and then
> deinstalled/reinstalled php5 (when 5.3) and lost the extension. I was
> surprised by a user asking for it to be installed.
That's a good reason to remove it from php52 :-) If it wasn't added
there, you wouldn't be surprised.
And as a user, will you not be surprised if pdo_mysql is present and not
pdo_firebird?
The only reason for the presence of a pdo driver (sqlite) in
php5-extensions is that it's enabled by default in php installation,
otherwise zero pdo drivers would be listed there.
--
Alex Dupre
On 8/6/2012 8:47 AM, Alex Dupre wrote:
> Bryan Drewery ha scritto:
>> ports/149942 added PDO_MYSQL to php52-extensions in 2010. Personally at
>> some point I had selected that in php52, and then
>> deinstalled/reinstalled php5 (when 5.3) and lost the extension. I was
>> surprised by a user asking for it to be installed.
>
> That's a good reason to remove it from php52 :-) If it wasn't added
> there, you wouldn't be surprised.
> And as a user, will you not be surprised if pdo_mysql is present and not
> pdo_firebird?
> The only reason for the presence of a pdo driver (sqlite) in
> php5-extensions is that it's enabled by default in php installation,
> otherwise zero pdo drivers would be listed there.
>
Why even have the meta port then?
As for pdo_firebird, I almost did submit a patch to add that and other
missing extensions, but it would require bsd.php.mk updates as well, so
I was keeping it simple.
--
Regards,
Bryan Drewery
bdrewery@freenode/EFNet
Bryan Drewery ha scritto:
> As for pdo_firebird, I almost did submit a patch to add that and other
> missing extensions, but it would require bsd.php.mk updates as well, so
> I was keeping it simple.
If you submit a patch including the necessary changes to bsd.php.mk to
support also "pdo_dblib", "pdo_firebird" and "pdo_odbc" I'll commit it.
--
Alex Dupre
State Changed From-To: feedback->closed Committed. |