Bug 171117
| Summary: | [PATCH] security/knock: Duplicated flags | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | changlp | ||||
| Component: | Individual Port(s) | Assignee: | Sofian Brabez <sbz> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | sbz | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-ports-bugs->sbz Over to maintainer (via the GNATS Auto Assign Tool) Author: sbz Date: Wed Aug 29 10:54:47 2012 New Revision: 303331 URL: http://svn.freebsd.org/changeset/ports/303331 Log: - Fix duplicated flags PR: ports/171117 Submitted by: Lung-Pin Chang <changlp at cs.nctu.edu.tw> Modified: head/security/knock/Makefile head/security/knock/files/knockd.in Modified: head/security/knock/Makefile ============================================================================== --- head/security/knock/Makefile Wed Aug 29 10:07:06 2012 (r303330) +++ head/security/knock/Makefile Wed Aug 29 10:54:47 2012 (r303331) @@ -7,6 +7,7 @@ PORTNAME= knock PORTVERSION= 0.5 +PORTREVISION= 1 PORTEPOCH= 1 CATEGORIES= security MASTER_SITES= http://www.zeroflux.org/proj/knock/files/ \ Modified: head/security/knock/files/knockd.in ============================================================================== --- head/security/knock/files/knockd.in Wed Aug 29 10:07:06 2012 (r303330) +++ head/security/knock/files/knockd.in Wed Aug 29 10:54:47 2012 (r303331) @@ -27,7 +27,6 @@ load_rc_config $name : ${knockd_flags="-d"} command="%%PREFIX%%/bin/knockd" -command_args=${knockd_flags} pidfile="/var/run/knockd.pid" required_files=${knockd_conf} _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" State Changed From-To: open->closed Committed. Thanks! |
/etc/rc.subr already loads ${name}_flags as part of command line arguments. Putting $knockd_flags into $command_args causes the flags to be duplicated twice. e.g. root 75681 0.0 0.0 12324 1064 ?? Rs 9:18PM 0:00.88 /usr/local/bin/knockd -d -d Port maintainer (sbz@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99