Bug 171156

Summary: [patch] math/R -- remove limitation on unthreaded version of Tk
Product: Ports & Packages Reporter: Pietro Cerutti <gahr>
Component: Individual Port(s)Assignee: Brendan Fabeny <bf>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Pietro Cerutti freebsd_committer freebsd_triage 2012-08-29 09:40:10 UTC
math/R specifies that it requires an unthreaded version of Tk, via the USE_TK_NO_THREADS variable. I have successfully built R with a threaded version of Tk and run R --gui=Tk without any problems.

I kindly ask you to check whether this limitation is actually needed. If it's not the case, I'll remove the variable.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-29 09:40:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bf

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Pietro Cerutti freebsd_committer freebsd_triage 2012-09-18 11:22:42 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-09-18 11:22:43 UTC
Author: gahr
Date: Tue Sep 18 10:22:28 2012
New Revision: 304440
URL: http://svn.freebsd.org/changeset/ports/304440

Log:
  - Remove limitation on unthreaded version of Tk
  
  PR:		171156
  Submitted by:	gahr
  Approved by:	maintainer (timeout 20 days)

Modified:
  head/math/R/Makefile

Modified: head/math/R/Makefile
==============================================================================
--- head/math/R/Makefile	Tue Sep 18 10:19:30 2012	(r304439)
+++ head/math/R/Makefile	Tue Sep 18 10:22:28 2012	(r304440)
@@ -194,7 +194,6 @@ CONFIGURE_ARGS+=	--without-libpng
 .endif
 
 .if ${PORT_OPTIONS:MTCLTK}
-USE_TK_NO_THREADS=	yes
 USE_TK =		84+
 CONFIGURE_ARGS+=	--with-tcltk \
 			--with-tcl-config=${TCL_LIBDIR}/tclConfig.sh \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"