Bug 171249

Summary: multimedia/mplayer: build error if OSVERSION >=900033 and world is built WITHOUT_CLANG
Product: Ports & Packages Reporter: Herbert J. Skuhra <herbert>
Component: Individual Port(s)Assignee: Juergen Lock <nox>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
mplayer.diff.txt none

Description Herbert J. Skuhra 2012-09-02 13:30:12 UTC 
The build of multimedia/mplayer fails if OSVERSION >=900033 and clang is not installed (world built WITHOUT_CLANG):

Checking for clang version ... clang ./configure: clang: not found (experimental support only)
Checking for working compiler ... 
Error: Compiler is not functioning correctly. Check your installation and custom CFLAGS -O2 -pipe -O3 -fomit-frame-pointer -ffast-math -I/usr/local/live/liveMedia/include -I/usr/local/live/BasicUsageEnvironment/include -I/usr/local/live/UsageEnvironment/include -I/usr/local/live/groupsock/include -fno-strict-aliasing .

Fix: Patch attached!

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-02 13:30:21 UTC 
Maintainer of multimedia/mplayer,

Please note that PR ports/171249 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171249

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-02 13:30:26 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Thomas Zander 2012-09-04 07:06:21 UTC 
After some discussion on the mailing lists, attached is a patch that
resolves another build problem on some i386 boxes in addition to this
one. Please commit this.

Thanks,
Riggs
Comment 4 Juergen Lock freebsd_committer freebsd_triage 2012-09-04 21:34:01 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->nox

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-09-04 21:56:42 UTC 
Author: nox
Date: Tue Sep  4 20:56:27 2012
New Revision: 303671
URL: http://svn.freebsd.org/changeset/ports/303671

Log:
  - Only default to clang on amd64 and when /usr/bin/clang exists.
  - Set CPP= clang-cpp in that case too.
  - Fix windows codecs dir configure arg.
  - Bump PORTREVISIONs.
  
  PR:		ports/171249
  Submitted by:	"Herbert J. Skuhra" <h.skuhra@gmail.com>
  Submitted by:	Thomas Zander <thomas.e.zander@googlemail.com> (maintainer)

Modified:
  head/multimedia/mencoder/Makefile
  head/multimedia/mplayer/Makefile
  head/multimedia/mplayer/Makefile.options

Modified: head/multimedia/mencoder/Makefile
==============================================================================
--- head/multimedia/mencoder/Makefile	Tue Sep  4 20:46:54 2012	(r303670)
+++ head/multimedia/mencoder/Makefile	Tue Sep  4 20:56:27 2012	(r303671)
@@ -6,6 +6,7 @@
 
 PORTNAME=	mencoder
 PORTVERSION=	${MPLAYER_PORT_VERSION}
+PORTREVISION=	1
 
 COMMENT=	Convenient video file and movie encoder
 

Modified: head/multimedia/mplayer/Makefile
==============================================================================
--- head/multimedia/mplayer/Makefile	Tue Sep  4 20:46:54 2012	(r303670)
+++ head/multimedia/mplayer/Makefile	Tue Sep  4 20:56:27 2012	(r303671)
@@ -7,6 +7,7 @@
 
 PORTNAME=	mplayer
 PORTVERSION=	${MPLAYER_PORT_VERSION}
+PORTREVISION=	1
 
 COMMENT=	High performance media player supporting many formats
 

Modified: head/multimedia/mplayer/Makefile.options
==============================================================================
--- head/multimedia/mplayer/Makefile.options	Tue Sep  4 20:46:54 2012	(r303670)
+++ head/multimedia/mplayer/Makefile.options	Tue Sep  4 20:56:27 2012	(r303671)
@@ -51,17 +51,25 @@ CFLAGS+=	-O3 -fomit-frame-pointer -ffast
 .endif
 .endif #WITH_DEBUG
 
+#Supported architectures for clang
+.if ${ARCH} == "amd64"
+MPLAYER_CLANG_SUPPORTED_ARCH=	yes
+.endif
+
 .if !defined(WITHOUT_RTCPU)
 CONFIGURE_ARGS+=--enable-runtime-cpudetection
 .endif
 
-.if ${OSVERSION} >= 900033
+.if ${OSVERSION} >= 900033 \
+	&& exists(/usr/bin/clang) \
+	&& defined(MPLAYER_CLANG_SUPPORTED_ARCH)
 WITH_BASE_CLANG=yes
 .endif
 
 .if defined(WITH_BASE_CLANG)
 CC=		clang
 CXX=		clang++
+CPP=		clang-cpp
 .else
 .if defined(WITH_OTCHAIN)
 USE_GCC?=	4.6+
@@ -232,7 +240,7 @@ DEFAULT_CDROM_DEVICE=/dev/acd0
 .if ${ARCH} == "i386" || ${ARCH} == "amd64"
 .if !defined(WITHOUT_WIN32) && !defined(PACKAGE_BUILDING) && ${ARCH} == "i386"
 RUN_DEPENDS+=	${CODEC_DETECTION_FILE}:${CODEC_PORT}
-CONFIGURE_ARGS+=	--win32codecsdir=${LOCALBASE}/lib/win32
+CONFIGURE_ARGS+=	--codecsdir=${LOCALBASE}/lib/win32
 CODEC_PORT=	${PORTSDIR}/multimedia/win32-codecs
 CODEC_DETECTION_FILE!=	${MAKE} -f ${CODEC_PORT}/Makefile -V CODEC_DETECTION_FILE
 .else
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Juergen Lock freebsd_committer freebsd_triage 2012-09-04 21:58:42 UTC 
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!