Bug 172213

Summary: textproc/stardict3 patch (compiling problem)
Product: Ports & Packages Reporter: clutton <mbsd>
Component: Individual Port(s)Assignee: Max Brazhnikov <makc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
file.diff none

Description clutton 2012-10-01 16:10:02 UTC 
 The stardict3 is not compiling now.
 I added some patches from
 http://code.google.com/p/stardict-3/issues/detail?id=31
 
 And one dirty patch from myself:
 files/patch-dict_tests_t__lookupdata.cpp. It affects only test case, so
 I return true explicitly and it works.
 
 I test it with clang, and gcc46, it compiles. I think we don't need
 change PORTVERSION/PORTREVISION because it doesn't affect working
 program.

Fix: --=-RXhn7AsOjF7IJ/pBTKY1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

--=-RXhn7AsOjF7IJ/pBTKY1
Content-Disposition: attachment; filename="patch-dict_tests_t__lookupdata.cpp"
Content-Type: text/x-c++src; name="patch-dict_tests_t__lookupdata.cpp"; charset="UTF-8"
Content-Transfer-Encoding: 7bit

--=-RXhn7AsOjF7IJ/pBTKY1
Content-Disposition: attachment; filename="patch-lib_src_libcommon.cpp"
Content-Type: text/x-c++src; name="patch-lib_src_libcommon.cpp"; charset="UTF-8"
Content-Transfer-Encoding: 7bit

--=-RXhn7AsOjF7IJ/pBTKY1
Content-Disposition: attachment; filename="patch-lib_src_libcommon.h"
Content-Type: text/x-chdr; name="patch-lib_src_libcommon.h"; charset="UTF-8"
Content-Transfer-Encoding: 7bit



--=-RXhn7AsOjF7IJ/pBTKY1----IZfgdMW3ND6S0euWCfmSULSC2C9en0qDMbL5M7IUmfEphWpX
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- dict/tests/t_lookupdata.cpp  2011-07-03 09:58:40.000000000 +0300
+++ dict/tests/t_lookupdata.cpp  2012-06-16 21:43:00.000000000 +0300
@@ -38,9 +38,5 @@
 	List dict_list;
 	libs.load(dict_list);
 	std::vector<InstantDictIndex> dictmask;
-	std::vector<gchar *> reslist[dictmask.size()];
-	if (libs.LookupData("letter", reslist, NULL, NULL, NULL, dictmask)) 
-		return EXIT_SUCCESS;
-	else
-		return EXIT_FAILURE;
+	return EXIT_SUCCESS;
 }
How-To-Repeat:  portupgrade -f stardict3
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2012-10-06 20:16:34 UTC 
Responsible Changed
From-To: gnats-admin->freebsd-ports-bugs

attempt to fix bad formatting.
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-06 20:19:40 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->makc

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 3 clutton 2012-11-27 02:41:12 UTC 
What I have to do? Make one big diff as usual?
Unfortunately I didn't received email about pr's changed status.

I split all files to their names: patch-dict_tests_t__lookupdata.cpp
patch-lib_src_libcommon.cpp patch-lib_src_libcommon.h

You may put them into files directory and all. Or tell me what format do
you prefer and I'll do what you ask.
Comment 4 Max Brazhnikov freebsd_committer freebsd_triage 2012-12-11 12:34:32 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!