Bug 172362

Summary: [maintainer update] update for graphics/openimageio
Product: Ports & Packages Reporter: Shane <FreeBSD>
Component: Individual Port(s)Assignee: Marcus von Appen <mva>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
openimageio.patch.txt
none
patch-include__thread.h
none
openimageio.patch.txt
none
openimageio.patch.txt none

Description Shane 2012-10-05 17:00:34 UTC 
This is a small change to graphics/openimageio

While blender is effected by this update the new version just out will update it in the next few days.

commit reason --
gcc46 was found to create a corrupted binary on i386 targets.
gcc42 must be used for i386 binaries.

Fix: Patch attached with submission follows:
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2012-10-05 18:43:55 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mva

I'll take it.
Comment 2 Marcus von Appen freebsd_committer freebsd_triage 2012-10-07 14:44:18 UTC 
As discussed via mail already, graphics/openimageio has an automated
dependency on graphics/opencolorio, if the latter one is installed
already. This causes graphics/openimageio to fail at the moment, since
the setup and dependency chain for both can end up in circular
dependencies.

I'll wait for a fix from your side before proceeding.

Cheers
Marcus
Comment 3 Shane 2012-10-07 15:55:17 UTC 
Dependency issues fixed by breaking opencolorio into two ports.
Fix gcc atomics usage.
Remove dependency on tbb - was replacing gcc atomics
Added option to turn on/off colour management
Cleanup Makefile header
Comment 4 Shane 2012-10-29 03:59:20 UTC 
Found an issue with second level dependencies -
replacing the patch file with this fixes that issue.

Ensure that either USE_GCC_ATOMICS or USE_TBB is defined never both.
This prevents the inclusion of tbb/atomic.h which may not be installed 
as it isn't in the dependency list of ports using oiio.
Comment 5 Shane 2012-11-17 05:03:12 UTC 
While there are still delays from server issues I thought I would add 
the next update to replace the existing patch.

This updates to v1.1 which is the recommended version for blender with 
osl (the next update in a few weeks) It's also adapted to USE_GITHUB

While it breaks any existing blender builds against previous version - a 
rebuild will fix it so I don't see the need to keep an old version for 
compatibility.

I have also made this port a master to py-openimageio bringing just 
about everything into this port and will add the slave port change to 
the existing pr for it. I expect that most future updates won't need to 
modify py-openimageio now.

One question - py-openimageio only has one file in it's pkg-plist, while 
the old port used PLIST_FILES to define the one installed file, I can't 
find a way to make that work as a master/slave setup. The only way I 
could make it work was to have two pkg-plist files - I thought that was 
cleaner than commenting out the whole list like an optional install.
Comment 6 Shane 2012-12-10 21:05:30 UTC 
As the ports freeze is now over I wanted to get another update in before 
committing.

This patch replaces the previous one (1.1.0) and updates to 1.1.2 and 
also removes the thread option.

It was found that the option got turned around through the optionsng 
changes. The option doesn't actually enable threading within OIIO but is 
about supporting threads in the apps that make use of this library.
Comment 7 Marcus von Appen freebsd_committer freebsd_triage 2012-12-20 10:52:59 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!