Summary: | security/barnyard2, port update | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | pauls | ||||||
Component: | Individual Port(s) | Assignee: | Jason E. Hale <jhale> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | ||||||||
Priority: | Normal | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
pauls
2012-10-07 18:00:22 UTC
Class Changed From-To: sw-bug->maintainer-update rescue from pending. Responsible Changed From-To: gnats-admin->jhale I'll take it. The patch seems corrupted. Can you please send a unified diff (diff -ruN) or an svn diff as a regular attachment? State Changed From-To: open->feedback Awaiting new patch. Hopefully this is better. Paul Schmehl (pauls@utdallas.edu) Senior Information Security Analyst The University of Texas at Dallas On 10/7/12 7:24 PM, "Jason E. Hale" <jhale@freebsd.org> wrote: >The patch seems corrupted. Can you please send a unified diff (diff >-ruN) or >an svn diff as a regular attachment? State Changed From-To: feedback->open New patch received. There were a few changes I had to make. Could you please review the attached patch? - Trimmed Makefile header - Shortened COMMENT to keep it less than 70 characters - Changed POSTGRESQL -> PGSQL to keep it consistent with other ports - Used USE_AUTOTOOLS framework for build so that the correct build dependencies are installed - Changed MAKE_JOBS_UNSAFE -> MAKE_JOBS_SAFE because the port seems to build fine with make jobs enabled on tinderbox and in my own tests - The items that were in PORTDOCS3 seem more like examples so I changed the installation location to EXAMPLESDIR - QATty was failing with the PGSQL option, fixed that - Changed TCL option to use whatever TCL version is installed rather than forcing TCL-8.4, especially since TCL-8.5 is the default - Changed the handling of the barnyard2.conf file - The barnyard2-sguil port needed updated to use the new options framework --On October 11, 2012 6:34:59 AM -0500 "Jason E. Hale" <jhale@freebsd.org> wrote: > There were a few changes I had to make. Could you please review the > attached patch? > > - Trimmed Makefile header > - Shortened COMMENT to keep it less than 70 characters > - Changed POSTGRESQL -> PGSQL to keep it consistent with other ports > - Used USE_AUTOTOOLS framework for build so that the correct build > dependencies are installed > - Changed MAKE_JOBS_UNSAFE -> MAKE_JOBS_SAFE because the port seems to > build fine with make jobs enabled on tinderbox and in my own tests > - The items that were in PORTDOCS3 seem more like examples so I changed > the installation location to EXAMPLESDIR > - QATty was failing with the PGSQL option, fixed that > - Changed TCL option to use whatever TCL version is installed rather than > forcing TCL-8.4, especially since TCL-8.5 is the default > - Changed the handling of the barnyard2.conf file > - The barnyard2-sguil port needed updated to use the new options framework Thanks, Jason. I didn't realize that docs had moved into the OPTIONS framework as well. I was going to submit the barnyard2-sguil port update next, so thanks a lot for already taking care of that as well. I think moving the portdocs3 to examples is fine. Those are database schemas that would only apply if an option is selected. If you agree, I think this can be accepted into the ports structure, and I can start working on other ports that need to be updated. -- Paul Schmehl (pauls@utdallas.edu) Senior Information Security Analyst The University of Texas at Dallas http://www.utdallas.edu/infosecurity/ State Changed From-To: open->closed Committed. Thanks! |