Bug 172459
| Summary: | [PATCH] multimedia/ffmpegthumbnailer is missing gconf2 depend when GNOME OptionsNG has been selected | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | cheunghonyu | ||||||
| Component: | Individual Port(s) | Assignee: | Jason E. Hale <jhale> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | ||||||||
| Priority: | Normal | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Maintainer of multimedia/ffmpegthumbnailer,
Please note that PR ports/172459 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172459
--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Yes I'm agree. That dependency has to be here. State Changed From-To: feedback->open Maintainer approved. Responsible Changed From-To: freebsd-ports-bugs->jhale I'll take it. There were a few other changes that I needed to make. Could you review the attached patch? - Trimmed Makefile header - Dropped ABI version numbers from LIB_DEPENDS to satisfy portlint(1) - USE_GNOME= pkgconfig -> USE_PKGCONFIG= build - Removed soon to be deprecated WANT_GNOME - Install GCONF_SCHEMAS in PREFIX instead of LOCALBASE I've tested it, and it looks nice and works like before ;). I've done all dirty job, thank you very much. Is it normal to install gnome schemas like this: gconftool-2 --makefile-install-rule in post-install: ? I didn't see anything like this in any other port. It was my improvisation. So, if it is normal, please commit it. On Friday, October 12, 2012 00:54:21 paranormal wrote: > > Is it normal to install gnome schemas like this: > gconftool-2 --makefile-install-rule in post-install: ? > > I didn't see anything like this in any other port. > It was my improvisation. > > So, if it is normal, please commit it. > I looked at how bsd.gnome.mk handles gconf schemas and I think this is the way to go: .if ${PORT_OPTIONS:MGNOME} ${MKDIR} ${PREFIX}/etc/gconf/schemas ${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${PREFIX}/etc/gconf/schemas @${SETENV} GCONF_CONFIG_SOURCE=xml:${GCONF_CONFIG_OPTIONS}:${PREFIX}/${GCONF_CONFIG_DIRECTORY} \ gconftool-2 --makefile-install-rule ${PREFIX}/etc/gconf/schemas/${GCONF_SCHEMAS} \ > /dev/null || ${TRUE} .endif I'm more of a KDE guy, but this code seems to work fine on tinderbox. The problem with `gconftool-2 --get-default-source` is that it provides LOCALBASE instead of PREFIX. https://redports.org/buildarchive/20121012041037-24617/ - Jason I'm disagree. I'd like to see string:
install blablabla ffmpegthumbnailer.schemas
in installing output. That was the reason why I had been
deleting /dev/null || ${TRUE}
But if your insist: no problem.
oups, sorry. I was scared by red colour of string I thought it something
new.
> /dev/null || ${TRUE}
please commit your patch.
State Changed From-To: open->closed Committed. Thanks! |
multimedia/ffmpegthumbnailer with options GNOME fails in install phrase result from missing depends of gconftool-2 from devel/gconf2. Fix: add BUILD_DEPENDS+= gconftool-2:${PORTSDIR}/devel/gconf2 inside ${PORT_OPTIONS:MGNOME} section. Patch attached with submission follows: How-To-Repeat: In a fresh system without devel/gconf2 installed, multimedia/ffmpegthumbnailer with options GNOME fails to build. The following is error log =============================================================================== ===> Installing for ffmpegthumbnailer-gnome-2.0.8_1 ===> ffmpegthumbnailer-gnome-2.0.8_1 depends on executable: pkgconf - found ===> ffmpegthumbnailer-gnome-2.0.8_1 depends on shared library: png15 - found ===> ffmpegthumbnailer-gnome-2.0.8_1 depends on shared library: swscale - found ===> ffmpegthumbnailer-gnome-2.0.8_1 depends on shared library: jpeg.11 - found ===> ffmpegthumbnailer-gnome-2.0.8_1 depends on shared library: glib-2.0.0 - found ===> Generating temporary packing list ===> Checking if multimedia/ffmpegthumbnailer already installed Making install in man gmake[1]: Entering directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/man' gmake[2]: Entering directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/man' gmake[2]: Nothing to be done for `install-exec-am'. .././install-sh -c -d '/usr/local/man/man1' install -o root -g wheel -m 444 ffmpegthumbnailer.1 '/usr/local/man/man1' gmake[2]: Leaving directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/man' gmake[1]: Leaving directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/man' gmake[1]: Entering directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8' gmake[2]: Entering directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8' ./install-sh -c -d '/usr/local/lib' /bin/sh ./libtool --mode=install /usr/bin/install -c -o root -g wheel libffmpegthumbnailer.la '/usr/local/lib' libtool: install: /usr/bin/install -c -o root -g wheel .libs/libffmpegthumbnailer.so.4 /usr/local/lib/libffmpegthumbnailer.so.4 libtool: install: (cd /usr/local/lib && { ln -s -f libffmpegthumbnailer.so.4 libffmpegthumbnailer.so || { rm -f libffmpegthumbnailer.so && ln -s libffmpegthumbnailer.so.4 libffmpegthumbnailer.so; }; }) libtool: install: (cd /usr/local/lib && { ln -s -f libffmpegthumbnailer.so.4 libffmpegthumbnailer.so || { rm -f libffmpegthumbnailer.so && ln -s libffmpegthumbnailer.so.4 libffmpegthumbnailer.so; }; }) libtool: install: /usr/bin/install -c -o root -g wheel .libs/libffmpegthumbnailer.lai /usr/local/lib/libffmpegthumbnailer.la libtool: install: /usr/bin/install -c -o root -g wheel .libs/libffmpegthumbnailer.a /usr/local/lib/libffmpegthumbnailer.a libtool: install: chmod 644 /usr/local/lib/libffmpegthumbnailer.a libtool: install: ranlib /usr/local/lib/libffmpegthumbnailer.a ./install-sh -c -d '/usr/local/bin' /bin/sh ./libtool --mode=install install -s -o root -g wheel -m 555 ffmpegthumbnailer '/usr/local/bin' libtool: install: install -o root -g wheel -m 555 -s .libs/ffmpegthumbnailer /usr/local/bin/ffmpegthumbnailer ./install-sh -c -d '/usr/local/include' ./install-sh -c -d '/usr/local/include/libffmpegthumbnailer' install -o root -g wheel -m 444 libffmpegthumbnailer/videothumbnailer.h libffmpegthumbnailer/videothumbnailerc.h libffmpegthumbnailer/imagetypes.h libffmpegthumbnailer/ifilter.h libffmpegthumbnailer/videoframe.h libffmpegthumbnailer/filmstripfilter.h '/usr/local/include/libffmpegthumbnailer' ./install-sh -c -d '/usr/local/libdata/pkgconfig' install -o root -g wheel -m 444 libffmpegthumbnailer.pc '/usr/local/libdata/pkgconfig' gmake[2]: Leaving directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8' gmake[1]: Leaving directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8' cd /wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/ && /usr/bin/env TMPDIR="/tmp" TMPDIR="/tmp" SHELL=/bin/sh NO_LINT=YES PREFIX=/usr/local LOCALBASE=/usr/local MOTIFLIB="-L/usr/local/lib -lXm -lXp" LIBDIR="/usr/lib" CC="cc" CFLAGS="-O2 -pipe -fno-strict-aliasing" CPP="cpp" CPPFLAGS=" -I/usr/local/include" LDFLAGS=" -pthread -L/usr/local/lib" CXX="c++" CXXFLAGS="-O2 -pipe -fno-strict-aliasing" MANPREFIX="/usr/local" BSD_INSTALL_PROGRAM="install -s -o root -g wheel -m 555" BSD_INSTALL_LIB="install -s -o root -g wheel -m 444" BSD_INSTALL_SCRIPT="install -o root -g wheel -m 555" BSD_INSTALL_DATA="install -o root -g wheel -m 444" BSD_INSTALL_MAN="install -o root -g wheel -m 444" make install-pkgconfigDATA ./install-sh -c -d '/usr/local/libdata/pkgconfig' install -o root -g wheel -m 444 libffmpegthumbnailer.pc '/usr/local/libdata/pkgconfig' install -o root -g wheel -m 444 /usr/ports/multimedia/ffmpegthumbnailer/files/ffmpegthumbnailer.schemas /usr/local/etc/gconf/schemas gconftool-2: not found env: gconftool-2: No such file or directory *** [post-install] Error code 127 Stop in /usr/ports/multimedia/ffmpegthumbnailer.