Bug 172572

Summary: [patch] devel/gdb: add missing thread names
Product: Ports & Packages Reporter: nkoch
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description nkoch 2012-10-10 13:00:01 UTC 
I have an application that sets thread names using pthread_set_name_np().
Those names are visible using FreeBSD's gdb 6.1.1, but not using
the latest gdb 7.5 from ports.
The required function and its use in fbsd-threads.c are missing
in the port's fbsd-threads.c.patch.

I simply added the function without changes and it seems to work.

Any reason why this is missing in the port? Any known problems?
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-10 13:00:13 UTC 
Maintainer of devel/gdb,

Please note that PR ports/172572 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172572

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-10 13:00:14 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 luca.pizzamiglio 2012-10-16 16:17:55 UTC 
Hi all!

thread's names will be added in the next patch I'll submit, merging
other modifications
I've received another approach to manage thread's names, parsing the
kinfo_proc structure.

There're some advantages using the ptrace approach?

Thanks for the support

Best regards
Luca
Comment 4 nkoch 2012-10-16 16:31:21 UTC 
Am 16.10.2012 17:17, schrieb Luca Pizzamiglio:
> Hi all!
>
> thread's names will be added in the next patch I'll submit, merging
> other modifications
> I've received another approach to manage thread's names, parsing the
> kinfo_proc structure.
>
> There're some advantages using the ptrace approach?
>
> Thanks for the support
>
> Best regards
> Luca

Hi,
it was a quick&dirty hack to see threads' names.
I just diff'ed system gdb sources and port gdb sources.

I will appreciate any patch that improves my
debug experience;-)

Best regards,
Norbert Koch
Comment 5 luca.pizzamiglio 2012-10-16 16:47:12 UTC 
In a week or less I should commit a cumulative patch that includes
several small improves and thread names support.
Thanks for the clarification and the support

Best regards,
Luca

On Tue, Oct 16, 2012 at 5:31 PM, Norbert Koch <nkoch@demig.de> wrote:
> Am 16.10.2012 17:17, schrieb Luca Pizzamiglio:
>> Hi all!
>>
>> thread's names will be added in the next patch I'll submit, merging
>> other modifications
>> I've received another approach to manage thread's names, parsing the
>> kinfo_proc structure.
>>
>> There're some advantages using the ptrace approach?
>>
>> Thanks for the support
>>
>> Best regards
>> Luca
>
> Hi,
> it was a quick&dirty hack to see threads' names.
> I just diff'ed system gdb sources and port gdb sources.
>
> I will appreciate any patch that improves my
> debug experience;-)
>
> Best regards,
> Norbert Koch
Comment 6 luca.pizzamiglio 2012-10-17 16:22:35 UTC 
Thread names and some other improvements are added on this PR ports/172828
that also close this current one.

Best regards
Comment 7 Raphael Kubo da Costa freebsd_committer freebsd_triage 2012-10-28 21:42:45 UTC 
State Changed
From-To: feedback->closed

Closing since this is part of ports/172828.