Bug 172777
| Summary: | New port: net/libnfs a client library for accessing NFS shares | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Manuel Creach <manuel.creach> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Manuel Creach
2012-10-16 09:10:01 UTC
Class Changed From-To: update->change-request Fix category (new ports should be change-requests) (via the GNATS Auto Assign Tool) A few comments after looking at the Makefile: o It would be good if you could adapt the header comments to the new format. o Setting PORTREVISION to 1 (and in that location) is wrong, since this is a new port. I suggest running `portlint' to look for this kind of issue. o Try using USE_GITHUB and its related variables so you do not need to hardcode the whole MASTER_SITES address. o You probably need not override FETCH_ARGS. o The port itself already seems to always set _FILE_OFFSET_BITS to 64, so the CFLAGS addition is redundant. o The port does not list any build dependency except for the autotools stuff, so I wonder if changing LDFLAGS is really necessary. o Still on the same subject, are you sure you need to change ACLOCAL_ARGS and and AUTOMAKE_ARGS? I followed your recommendations about the Makefile: Here is what I did : o Header was adapted to the new format o PORTREVISION has been removed o Tried to use github variables but the file is unavailable with the generated URL, so I stayed with hardcoded MASTER_SITES o Changed the MASTER_SITES variable, so FETCH_ARGS override is not necessary o Removed CFLAGS and LDFLAGS as you suggested o ACLOCAL_ARGS and AUTOMAKE_ARGS are really needed, otherwise autoreconf will fail  Author: pawel Date: Tue Feb 26 23:12:28 2013 New Revision: 313012 URL: http://svnweb.freebsd.org/changeset/ports/313012 Log: LIBNFS is a client library for accessing NFS shares over a network. LIBNFS offers three different APIs, for different use : 1, RAW : A fully async low level RPC library for NFS protocols 2, NFS ASYNC : A fully asynchronous library for high level vfs functions 3, NFS SYNC : A synchronous library for high level vfs functions WWW: https://github.com/sahlberg/libnfs PR: ports/172777 Submitted by: Manuel Creach <manuel.creach@icloud.com> Added: head/net/libnfs/ head/net/libnfs/Makefile (contents, props changed) head/net/libnfs/distinfo (contents, props changed) head/net/libnfs/pkg-descr (contents, props changed) head/net/libnfs/pkg-plist (contents, props changed) Modified: head/net/Makefile Modified: head/net/Makefile ============================================================================== --- head/net/Makefile Tue Feb 26 23:12:03 2013 (r313011) +++ head/net/Makefile Tue Feb 26 23:12:28 2013 (r313012) @@ -325,6 +325,7 @@ SUBDIR += libnet SUBDIR += libnet10 SUBDIR += libnetdude + SUBDIR += libnfs SUBDIR += libnids SUBDIR += libnss-mysql SUBDIR += liboauth Added: head/net/libnfs/Makefile ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/net/libnfs/Makefile Tue Feb 26 23:12:28 2013 (r313012) @@ -0,0 +1,28 @@ +# Created by: Manuel Creach <manuel.creach@icloud.com> +# $FreeBSD$ + +PORTNAME= libnfs +PORTVERSION= 1.3.0 +CATEGORIES= net +MASTER_SITES= http://cloud.github.com/downloads/sahlberg/${PORTNAME}/ + +MAINTAINER= manuel.creach@icloud.com +COMMENT= Client library for accessing NFS shares over a network + +LICENSE= LGPL21 GPLv3 +LICENSE_COMB= multi +LICENSE_FILE= ${WRKSRC}/COPYING + +USE_GMAKE= yes +USE_AUTORECONF= yes +USE_AUTOTOOLS= aclocal autoheader automake autoconf libtoolize +ACLOCAL_ARGS= -I. +AUTOMAKE_ARGS= --add-missing +USE_PKGCONFIG= build +USE_LDCONFIG= yes + +post-patch: + ${REINPLACE_CMD} 's|$$(libdir)/\(pkgconfig\)|$$(prefix)/libdata/\1|' \ + ${WRKSRC}/Makefile.am + +.include <bsd.port.mk> Added: head/net/libnfs/distinfo ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/net/libnfs/distinfo Tue Feb 26 23:12:28 2013 (r313012) @@ -0,0 +1,2 @@ +SHA256 (libnfs-1.3.0.tar.gz) = 812c8ae47c8b0c37c21f313b669d4dc8e8025007ba7492102eb67508eb0a82cc +SIZE (libnfs-1.3.0.tar.gz) = 57928 Added: head/net/libnfs/pkg-descr ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/net/libnfs/pkg-descr Tue Feb 26 23:12:28 2013 (r313012) @@ -0,0 +1,8 @@ +LIBNFS is a client library for accessing NFS shares over a network. + +LIBNFS offers three different APIs, for different use : +1, RAW : A fully async low level RPC library for NFS protocols +2, NFS ASYNC : A fully asynchronous library for high level vfs functions +3, NFS SYNC : A synchronous library for high level vfs functions + +WWW: https://github.com/sahlberg/libnfs Added: head/net/libnfs/pkg-plist ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/net/libnfs/pkg-plist Tue Feb 26 23:12:28 2013 (r313012) @@ -0,0 +1,12 @@ +lib/libnfs.la +lib/libnfs.a +lib/libnfs.so +lib/libnfs.so.1 +include/nfsc/libnfs-raw-mount.h +include/nfsc/libnfs-raw-nfs.h +include/nfsc/libnfs-raw-portmap.h +include/nfsc/libnfs-raw-rquota.h +include/nfsc/libnfs-raw.h +include/nfsc/libnfs.h +libdata/pkgconfig/libnfs.pc +@dirrm include/nfsc _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" State Changed From-To: open->closed New port added, with minor changes. Thanks! |
