Bug 172853

Summary: [MAINTAINER-UPDATE][PATCH] please update devel/hwloc to 1.5.1
Product: Ports & Packages Reporter: Eijiro Shibusawa <phd_kimberlite>
Component: Individual Port(s)Assignee: Jason E. Hale <jhale>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
hwloc.diff none

Description Eijiro Shibusawa 2012-10-18 14:20:00 UTC 
Attached patch updates devel/hwloc to 1.5.1.

NOTE:
- This port was tested with portlint 2.13.13 and tinderbox.
  tinderbox logs are available at redports.org.
  https://redports.org/buildarchive/20121018012313-871/
- This release includes bug fixes on FreeBSD environment.
  Please refer the release announcement.
  http://www.open-mpi.org/community/lists/hwloc-announce/2012/10/0045.php

Fix: Patch attached with submission follows:
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2012-10-20 09:43:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jhale

I'll take it.
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2012-10-20 12:49:33 UTC 
Could you please review the attached diff?

I propose the following changes:

- Trim Makefile header
- Use the USE_PKGCONFIG macro; USE_GNOME=pkgconfig is deprecated
- Use USE_GNOME=gnomehack to remove the REINPLACE_CMD for the pkgconfig file
- Use the PORTDOCS macro to cut down the size of pkg-plist
- Convert to new options framework
- Move files/manpages to Makefile.man ... it is more standard and will have a 
$FreeBSD$ revision tag
- Use the MLINKS macro to deal with manpage links
- Sort pkg-plist
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2012-10-20 12:50:27 UTC 
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 4 Eijiro Shibusawa 2012-10-20 15:16:56 UTC 
Hi, Mr. Hale,

Thank you very much for suggestions to the port.
I approve your proposal.
Please commit your diff.

Best regards,
Shibusawa

On 2012/10/20 20:49, Jason E. Hale wrote:
> Could you please review the attached diff?
> 
> I propose the following changes:
> 
> - Trim Makefile header
> - Use the USE_PKGCONFIG macro; USE_GNOME=pkgconfig is deprecated
> - Use USE_GNOME=gnomehack to remove the REINPLACE_CMD for the pkgconfig file
> - Use the PORTDOCS macro to cut down the size of pkg-plist
> - Convert to new options framework
> - Move files/manpages to Makefile.man ... it is more standard and will have a 
> $FreeBSD$ revision tag
> - Use the MLINKS macro to deal with manpage links
> - Sort pkg-plist
>
Comment 5 Jason E. Hale freebsd_committer freebsd_triage 2012-10-20 15:59:28 UTC 
State Changed
From-To: feedback->open

Maintainer has approved.
Comment 6 Jason E. Hale freebsd_committer freebsd_triage 2012-10-22 14:41:20 UTC 
State Changed
From-To: open->closed

Committed. Thanks!