Bug 173006

Summary: [new port] devel/git-review
Product: Ports & Packages Reporter: dereckson
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.shar
none
patch.txt none

Description dereckson 2012-10-23 23:50:00 UTC 
This is a "git review" command for Git.

____________

/usr/ports/devel # cat git-review/pkg-descr
Git review allows you to extend git to interact more easily with a Gerrit server
from the console.

It allows you to push change to review, download a changeset into a new branch,
push a change as draft or push an amended change as new patchset.

WWW: https://launchpad.net/git-review

____________

Tested locally and through redports.

Fix: Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2012-10-24 08:09:32 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

ports PR.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2012-10-24 22:56:52 UTC 
Thanks for the patch. It would be nice if you could use the new style
for the Makefile header. There's also a line saying

  USE_PYTHON=   #yes

I'm not sure if you intended to remove the whole line or if `yes' should
be uncommented out.
Comment 3 dereckson 2012-10-24 23:40:27 UTC 
On Wed, Oct 24, 2012 at 11:56 PM, Raphael Kubo da Costa
<rakuco@freebsd.org> wrote:
> Thanks for the patch. It would be nice if you could use the new style
> for the Makefile header. There's also a line saying
>
>   USE_PYTHON=   #yes
>
> I'm not sure if you intended to remove the whole line or if `yes' should
> be uncommented out.

I used for USE_PYTHON a convention used elsewhere in ports (for
EXTRACT_ONLY or NO_BUILD for example). But USE_PYTHON supports "yes"
as parameter for "any version", so you the good syntax is:
USE_PYTHON=   yes

-- 
Sébastien Santoro aka Dereckson
http://www.dereckson.be/
Comment 4 Raphael Kubo da Costa freebsd_committer freebsd_triage 2012-11-04 15:43:27 UTC 
State Changed
From-To: open->closed

New port added, thanks. I have committed your latest patch, the only 
difference being moving the LICENSE part to the right section of the 
Makefile.