Bug 173028

Summary: [PATCH] graphics/pngcrush: update to 1.7.41
Product: Ports & Packages Reporter: Naram Qashat <cyberbotx>
Component: Individual Port(s)Assignee: Joseph S. Atkinson <jsa>
Status: Closed FIXED    
Severity: Affects Only Me CC: jsa
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
pngcrush-1.7.41.patch none

Description Naram Qashat 2012-10-24 16:40:00 UTC 
- Update to 1.7.41 (upstream fix, as 1.7.40 was not writing the output file)
- Removed -DPNGCRUSH_COUNT_COLORS from CFLAGS as this was removed from pngcrush
  upstream as of version 1.7.39.

Port maintainer (jsa@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: update, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-24 16:40:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jsa

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Joseph S. Atkinson freebsd_committer freebsd_triage 2012-10-28 07:24:17 UTC 
Hello Naram,

I will be glad to update the port.

Please note, from the release notes and code, PNGCRUSH_COUNT_COLORS is 
not removed completely. Only some features which the author is no longer 
interested in maintaining. There are still functions related to this 
feature.

Further, 1.7.41 is a reversion to 1.7.38 where all such features are 
still present. Is there a specific reason you feel this feature should 
be disabled?
Comment 3 Naram Qashat 2012-10-28 08:51:19 UTC 
On 10/28/12 03:24, Joseph S. Atkinson wrote:
> Hello Naram,
>
> I will be glad to update the port.
>
> Please note, from the release notes and code, PNGCRUSH_COUNT_COLORS is not
> removed completely. Only some features which the author is no longer interested
> in maintaining. There are still functions related to this feature.
>
> Further, 1.7.41 is a reversion to 1.7.38 where all such features are still
> present. Is there a specific reason you feel this feature should be disabled?
>

No, I had actually missed noticing that until after I had already submitted the 
PR.  The feature can be left enabled.

Thanks,
Naram Qashat
Comment 4 Joseph S. Atkinson freebsd_committer freebsd_triage 2012-10-29 21:03:32 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!