Summary: | [maintainer] mail/opendkim update to 2.7.1 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Hirohisa Yamaguchi <umq> | ||||||||
Component: | Individual Port(s) | Assignee: | Guido Falsi <madpilot> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Only Me | ||||||||||
Priority: | Normal | ||||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Attachments: |
|
Description
Hirohisa Yamaguchi
2012-10-31 02:10:00 UTC
Responsible Changed From-To: freebsd-ports-bugs->madpilot I'll take it. Hi, While looking at your submission I changed a few things. First you are looking at the WITH_BDB_BASE and WITH_LIBXML2 variables old style. I modified the port to expose the two via BDB_BASE and XML options. I also changed the port to using bsd.port.options.mk instead of bsd.port.(pre|post).mk. While here I moved the PORTDOCS=* variable out of the conditional, since that is automatic: If the port installs nothing in ${DOCSDIR} PORTDOCS=* will add nothing to the plist. Also I trimmed the Makefile headers as required recently: http://blogs.freebsdish.org/portmgr/2012/09/17/change-to-the-header-in-ports-makefiles-take-two/ If you're not interested in the Created by: lines you also have the option to remove them, just tell me what you prefer. I'm attaching a revised diff. Could you please test it and see if you can approve it? If you have any doubt or objection to my changes just tell me :) Thanks. -- Guido Falsi <madpilot@FreeBSD.org> State Changed From-To: open->feedback Ask for submitter approval. Hi, Thanks for looking at my patch. > First you are looking at the WITH_BDB_BASE and WITH_LIBXML2 variables > old style. > I modified the port to expose the two via BDB_BASE and XML options. I understand the point and added XML_DESC. > I also changed the port to using bsd.port.options.mk instead of > bsd.port.(pre|post).mk. > While here I moved the PORTDOCS=* variable out of the conditional, since > that is automatic: If the port installs nothing in ${DOCSDIR} PORTDOCS=* > will add nothing to the plist. > Also I trimmed the Makefile headers as required recently: I agree with you on these points. > I'm attaching a revised diff. Could you please test it and see if you > can approve it? > If you have any doubt or objection to my changes just tell me :) I attach an updated patch with build fix and typo correction. Regards, -- Hirohisa Yamaguchi <umq@ueo.co.jp> State Changed From-To: feedback->open Feedback received. State Changed From-To: open->closed Committed. Thanks! |