Bug 173243

Summary: [PATCH] textproc/goldendict: Changed License place, WWW, simplified MASTER_SITES
Product: Ports & Packages Reporter: nemysis <nemysis>
Component: Individual Port(s)Assignee: Boris Samorodov <bsam>
Status: Closed FIXED    
Severity: Affects Only Me CC: bsam
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
goldendict-1.0.1_5.patch none

Description nemysis 2012-10-31 17:30:00 UTC
Makefile changed:
+MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/1.0/

Changed place that portlint works
+LICENSE=	GPLv3

Channged pkg-descr
+WWW: http://goldendict.org/

Port maintainer (bsam@FreeBSD.org) is cc'd.

Generated and tested manually, tested with port test and with RedPorts (all RELEASES, CLANG), sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
Original Port:
portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
FATAL: Makefile: extra item "LIB_DEPENDS" placed in the LICENSE section.
WARN: Makefile: "LICENSE" has to appear earlier.
1 fatal error and 3 warnings found.

This patch:
portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .0 in hunspell-1.3.0 unless it is really necessary.
0 fatal errors and 3 warnings found.

port test: clean

Build log

https://redports.org/buildarchive/20121031144532-58273/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-31 17:30:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bsam

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Boris Samorodov freebsd_committer freebsd_triage 2012-11-03 18:03:50 UTC
State Changed
From-To: open->closed

Committed with some changes.  Notes: 1. I understand but do not accept 
MASTER_SITES change you proposed.  Current state of MASTER_SITES make 
unnecessary changes to itself when PORTVERSION is changed.  2. As per 
DISTNAME... I'd say that currently it's more obvious than the way you 
propose... 

The rest was accepted. Thanks!