Bug 173277

Summary: bsd.php.mk makes php-5.4 incompatibility very unclear
Product: Ports & Packages Reporter: Adam Weinberger <adamw>
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Adam Weinberger freebsd_committer freebsd_triage 2012-11-02 01:50:01 UTC 
mail/squirrelmail does not work with php-5.4 yet. As a result, I have to set
IGNORE_WITH_PHP=	5
in the Makefile.

The problem is that the resulting error message is:
===>  squirrelmail-1.4.22_2 cannot install: doesn't work with PHP version : 5 (Doesn't support PHP 5).

This is inaccurate, and as a result I have received far too many emails
asking why I "removed" php-5 compatibility. bsd.php.mk will not acknowledge
IGNORE_WITH_PHP=	54
as a valid alternative. The wording of the message is obviously unclear.

Fix: 

bsd.php.mk should either accept (and print in the resulting error message)
the value "54" as an alias for "5", or the IGNORE_WITH_PHP=5 error message
should be manually set to print a more helpful message.

Even the ability to append a useful message to the confusing canned message
would help.

If I'm missing something here please let me know.
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2012-11-02 01:58:41 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer.
Comment 2 Alex Dupre freebsd_committer freebsd_triage 2012-11-05 13:13:25 UTC 
State Changed
From-To: open->feedback

What about a message like the following? 

squirrelmail-2 cannot be installed: doesn't work with lang/php5 port (doesn't support PHP 5-Latest)
Comment 3 adamw 2012-11-16 21:35:10 UTC 
Yikes! Your reply got buried, sorry about taking so long to reply!!

"doesn't support PHP 5-Latest" is definitely much clearer, but is still =
sortof vague.

It still seems to me that "doesn't support PHP 5.4" is definitely =
optimal from a clarity standpoint, but "doesn't support PHP 5-Latest" =
would be a reasonable alternative if it were possible to extend the =
error message, i.e. if it could print an optional string at the end so =
that I could clarify what people need to do about the error.

# Adam=
Comment 4 Alex Dupre freebsd_committer freebsd_triage 2012-12-17 15:50:38 UTC 
State Changed
From-To: feedback->closed

Message improved, thanks.