Bug 173442

Summary:	[zfs] ZFS ZVOL snapshot device nodes are not removed
Product:	Base System	Reporter:	Petri Helenius <pete>
Component:	kern	Assignee:	Andriy Gapon <avg>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Unspecified
Hardware:	Any
OS:	Any

Description Petri Helenius 2012-11-07 10:20:00 UTC

	The zvol snapshots are not removed from /dev/zvol until reboot

How-To-Repeat: zfsmaster# zfs create  zroot/iscsi
zfsmaster# zfs create -V 50M zroot/iscsi/test1
zfsmaster# zfs create -V 50M zroot/iscsi/test2
zfsmaster# cd /dev/zvol/zroot/
zfsmaster# cd /dev/zvol/zroot/
iscsi/  swap%   swap@1% swap@3% swap@6% 
zfsmaster# cd /dev/zvol/zroot/iscsi/
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
zfsmaster# zfs snapshot -r zroot/iscsi@snap1
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
zfsmaster# zfs snapshot -r zroot/iscsi@snap2
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
zfsmaster# zfs snapshot -r zroot/iscsi@snap3
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
zfsmaster# zfs snapshot -r zroot/iscsi@snap4
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# zfs destroy -r zroot/iscsi@snap2
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# zfs destroy -r zroot/iscsi@snap1
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# zfs destroy -r zroot/iscsi@snap3
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# zfs destroy -r zroot/iscsi@snap4
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# dd if=test1@snap1 of=/dev/null
dd: test1@snap1: No such file or directory
zfsmaster# zfs snapshot -r zroot/iscsi@snap5
zfsmaster# dd if=test1@snap5 of=/dev/null
102400+0 records in
102400+0 records out
52428800 bytes transferred in 2.021984 secs (25929383 bytes/sec)
zfsmaster#

Comment 1 petri 2012-11-07 10:53:23 UTC

https://www.illumos.org/issues/3170

Comment 2 Andriy Gapon freebsd_committer

2012-11-07 20:29:27 UTC

Can you confirm that the proposed fix in the Illumos bug report works for you?

-- 
Andriy Gapon

Comment 3 petri 2012-11-08 06:28:17 UTC

On 9.1-RC3 it works for me.

Pete

Comment 4 Mark Linimon freebsd_committer

2012-11-08 23:50:02 UTC

Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).

Comment 5 Andriy Gapon freebsd_committer

2012-11-10 12:34:30 UTC

Responsible Changed
From-To: freebsd-fs->avg

I'll take it.

Comment 6 Andriy Gapon freebsd_committer

2012-11-19 12:40:07 UTC

State Changed
From-To: open->patched

Patched in head.

Comment 7 Andriy Gapon freebsd_committer

2012-12-01 18:23:56 UTC

State Changed
From-To: patched->closed

Should be fixed now.