Bug 17360

Summary: [PATCH] Cleanup bug in pam_ssh
Product: Base System Reporter: ajk <ajk>
Component: binAssignee: Brian Feldman <green>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description ajk 2000-03-13 19:00:02 UTC 
[Sorry to submit this right after the tag went down, but I just
noticed it.]

Since pam_ssh is unable to use the libc environment calls (long
story), it uses a linked list to manage the environment on its own.
The list was not getting freed properly, which could cause a memory
leak in PAM applications that use this module.

This patch also ensures strict modes on the file containing ssh-agent
environment strings created in the user's ~/.ssh directory.

Fix: Apply this patch against src/crypto/openssh/pam_ssh/pam_ssh.c.
How-To-Repeat: 
Look at the env_destroy() function and see how it can't possibly
work.  :-)
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-07 15:36:42 UTC 
Responsible Changed
From-To: freebsd-bugs->kris

Johan Karlsson says that this seems to be fixed in rev 1.7 of 
src/crypto/openssh/pam_ssh/pam_ssh.c; over to the ssh 
maintainer for further investigation.
Comment 2 Kris Kennaway freebsd_committer freebsd_triage 2000-11-13 02:30:18 UTC 
Responsible Changed
From-To: kris->green

Green is taking over OpenSSH
Comment 3 Brian Feldman freebsd_committer freebsd_triage 2002-03-20 00:03:07 UTC 
State Changed
From-To: open->closed

This is majorly obsolete.