Bug 173743

Summary: Fix build problem for mplayer/mencoder when DEBUG option is set
Product: Ports & Packages Reporter: Thomas Zander <thomas.e.zander>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Thomas Zander 2012-11-20 21:50:00 UTC
When DEBUG option is set, on x86 architectures mplayer and mencoder fail to link due to missing symbols.

Fix: Patch is attached.
Note that this patch also contains the solution to the problem described in ports/172416

Patch attached with submission follows:
How-To-Repeat: Build mplayer and mencoder on x86 architectures with DEBUG option set.
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2013-03-13 17:30:20 UTC
Is this still an issue? I was able to build on i386 with DEBUG just
fine, without the patch.

-- 
Regards,
Bryan Drewery
bdrewery@freenode/EFNet

Comment 2 Thomas Zander 2013-03-13 17:48:09 UTC
On 13 March 2013 18:30, Bryan Drewery <bdrewery@freebsd.org> wrote:
> Is this still an issue? I was able to build on i386 with DEBUG just
> fine, without the patch.

It was definitely an issue back then when I submitted the pr.
Having said that, a couple of days ago I have sent a CFT for a quite
massive change to the port to the ports mailing list.
When this gets committed, this pr will become obsolete anyway. Having
this in mind, I think we can close this PR.

Best regards
Riggs
Comment 3 Bryan Drewery freebsd_committer freebsd_triage 2013-03-13 17:53:23 UTC
On 3/13/2013 12:48 PM, Thomas Zander wrote:
> On 13 March 2013 18:30, Bryan Drewery <bdrewery@freebsd.org> wrote:
>> Is this still an issue? I was able to build on i386 with DEBUG just
>> fine, without the patch.
> 
> It was definitely an issue back then when I submitted the pr.
> Having said that, a couple of days ago I have sent a CFT for a quite
> massive change to the port to the ports mailing list.
> When this gets committed, this pr will become obsolete anyway. Having
> this in mind, I think we can close this PR.
> 
> Best regards
> Riggs
> 


Sounds good. Thank you for the prompt reply.

-- 
Regards,
Bryan Drewery
bdrewery@freenode/EFNet
Comment 4 Bryan Drewery freebsd_committer freebsd_triage 2013-03-13 17:53:44 UTC
State Changed
From-To: open->closed

Per submitter request