Bug 173942

Summary:	net/bird and net/bird6 patch for -current
Product:	Ports & Packages	Reporter:	olivier
Component:	Individual Port(s)	Assignee:	Alexander V. Chernikov <melifaro>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description olivier 2012-11-26 19:20:01 UTC

net/bird and net/bird6 didn't build on a -current (clang incompatibility?):

conf.o: In function `add_tail_list':
conf.c:(.text+0x90): multiple definition of `add_tail_list'
cf-parse.tab.o:cf-parse.tab.c:(.text+0x90): first defined here
conf.o: In function `init_list':
conf.c:(.text+0x70): multiple definition of `init_list'
cf-parse.tab.o:cf-parse.tab.c:(.text+0x70): first defined here
conf.o: In function `insert_node':
conf.c:(.text+0x40): multiple definition of `insert_node'
cf-parse.tab.o:cf-parse.tab.c:(.text+0x40): first defined here
conf.o: In function `rem_node':
conf.c:(.text+0x60): multiple definition of `rem_node'
cf-parse.tab.o:cf-parse.tab.c:(.text+0x60): first defined here
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[2]: *** [all.o] Error 1
gmake[2]: Leaving directory `/usr/workdir/usr/ports/net/bird6/work/bird-1.3.8/obj/conf'
gmake[1]: *** [subdir] Error 2
gmake[1]: Leaving directory `/usr/workdir/usr/ports/net/bird6/work/bird-1.3.8/obj'
gmake: *** [all] Error 2
*** [do-build] Error code 1

Fix: 

Add this line to the makefile:
USE_GCC=       4.2+
How-To-Repeat: Build net/bird or net/bird6 on a -current.

Comment 1 Edwin Groothuis freebsd_committer

2012-11-26 19:20:13 UTC

Maintainer of net/bird,

Please note that PR ports/173942 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/173942

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org

Comment 2 Edwin Groothuis freebsd_committer

2012-11-26 19:20:14 UTC

State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

Comment 3 Alexander V. Chernikov freebsd_committer

2012-11-27 15:34:51 UTC

Responsible Changed
From-To: freebsd-ports-bugs->melifaro

Take

Comment 4 dfilter service freebsd_committer

2013-01-12 13:55:27 UTC

Author: melifaro (src committer)
Date: Sat Jan 12 13:55:20 2013
New Revision: 310270
URL: http://svnweb.freebsd.org/changeset/ports/310270

Log:
  Fix building bird with clang
  
  PR:		ports/173942
  Submitted by:	Olivier Cochard-Labbe <olivier at cochard.me>
  Approved by:	az

Modified:
  head/net/bird/Makefile
  head/net/bird6/Makefile

Modified: head/net/bird/Makefile
==============================================================================
--- head/net/bird/Makefile	Sat Jan 12 12:16:03 2013	(r310269)
+++ head/net/bird/Makefile	Sat Jan 12 13:55:20 2013	(r310270)
@@ -16,7 +16,7 @@ LICENSE=	GPLv2
 USE_BISON=	build
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
-USE_GCC=	4.2+
+USE_CSTD=	gnu89
 
 OPTIONS_DEFINE=	FIBS FIREWALL AGG
 FIBS_DESC=	Enable multiple fib support

Modified: head/net/bird6/Makefile
==============================================================================
--- head/net/bird6/Makefile	Sat Jan 12 12:16:03 2013	(r310269)
+++ head/net/bird6/Makefile	Sat Jan 12 13:55:20 2013	(r310270)
@@ -19,7 +19,7 @@ USE_BISON=	build
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--enable-ipv6
-USE_GCC=	4.2+
+USE_CSTD=	gnu89
 
 MAKE_JOBS_UNSAFE=	yes
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"

Comment 5 Alexander V. Chernikov freebsd_committer

2013-01-12 14:02:03 UTC

State Changed
From-To: feedback->closed

Fix commited, thanks!