Bug 17406

Summary: nis in /etc/host.conf breaks network programs
Product: Base System Reporter: sperber <sperber>
Component: confAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.0-RELEASE   
Hardware: Any   
OS: Any   

Description sperber 2000-03-16 14:30:01 UTC
Putting nis anywhere in /etc/host.conf makes basically every network
program (like ftp or telnet) segfault upon startup.

How-To-Repeat: Put nis in /etc/host.conf, do ftp ftp.freebsd.org.
Comment 1 Sheldon Hearn 2000-03-16 14:48:05 UTC
On Thu, 16 Mar 2000 06:26:49 PST, sperber@informatik.uni-tuebingen.de wrote:

> Putting nis anywhere in /etc/host.conf makes basically every network
> program (like ftp or telnet) segfault upon startup.

Do you have nisdomain set in /etc/rc.conf?

Is nis_client_enable and / or nis_server_enable set to YES in
/etc/rc.conf ?

Ciao,
Sheldon.
Comment 2 sperber 2000-03-16 14:59:30 UTC
>>>>> "Sheldon" == Sheldon Hearn <sheldonh@uunet.co.za> writes:

Sheldon> On Thu, 16 Mar 2000 06:26:49 PST, sperber@informatik.uni-tuebingen.de wrote:

>> Putting nis anywhere in /etc/host.conf makes basically every network
>> program (like ftp or telnet) segfault upon startup.

Sheldon> Do you have nisdomain set in /etc/rc.conf?

Sheldon> Is nis_client_enable and / or nis_server_enable set to YES in
Sheldon> /etc/rc.conf ?

Yes on both counts:

nisdomainname="wsi"
nis_client_enable="YES"

The configuration is the same as on our boxes still running
3.2-RELEASE, where everything works fine.

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
Comment 3 Yoshinobu Inoue 2000-03-16 15:12:24 UTC
> >Description:
> Putting nis anywhere in /etc/host.conf makes basically every network
> program (like ftp or telnet) segfault upon startup.
> >How-To-Repeat:
> Put nis in /etc/host.conf, do ftp ftp.freebsd.org.
> >Fix:

I confirmed that the problem also happens in my environment,
and the attached patch fixed it in my environment.  Could you
please try this patch, and try ftp or telnet again after
rebuilded and reinstalled src/lib/libc?

Thanks,
Yoshinobu Inoue

Index: name6.c
===================================================================
RCS file: /home/ncvs/src/lib/libc/net/name6.c,v
retrieving revision 1.6
diff -u -r1.6 name6.c
--- name6.c	2000/03/09 22:52:30	1.6
+++ name6.c	2000/03/16 15:08:32
@@ -840,7 +840,7 @@
 static struct hostent *
 _nis_ghbyname(const char *name, int af, int *errp)
 {
-	struct hostent *hp;
+	struct hostent *hp = NULL;
 
	if (af == AF_INET) {
		hp = _gethostbynisname(name, af);
Comment 4 Sheldon Hearn 2000-03-16 16:41:28 UTC
On Fri, 17 Mar 2000 01:39:12 +0900, Yoshinobu Inoue wrote:

> Woops, this seems to be already fixed in name6.c 1.6 to 1.7
> fix.

That probably needs to be merged to RELENG_4.  Then this PR can be
closed.  Do you agree?

Ciao,
Sheldon.
Comment 5 Yoshinobu Inoue 2000-03-16 16:51:50 UTC
> > Woops, this seems to be already fixed in name6.c 1.6 to 1.7
> > fix.
> 
> That probably needs to be merged to RELENG_4.  Then this PR can be
> closed.  Do you agree?

Yes of course, and it seems to be already merged to RELENG_4.

Thanks,

Yoshinobu Inoue
Comment 6 Sheldon Hearn 2000-03-16 17:02:02 UTC
On Fri, 17 Mar 2000 01:51:50 +0900, Yoshinobu Inoue wrote:

> Yes of course, and it seems to be already merged to RELENG_4.

Okay.  Do you think this warrants an ERRATA.TXT entry?

Ciao,
Sheldon.
Comment 7 Yoshinobu Inoue 2000-03-16 17:19:49 UTC
> On Fri, 17 Mar 2000 01:51:50 +0900, Yoshinobu Inoue wrote:
> 
> > Yes of course, and it seems to be already merged to RELENG_4.
> 
> Okay.  Do you think this warrants an ERRATA.TXT entry?

I think so (though I haven't ever written one, and don't know
exact rule for it).

Have anyone already started writing one? If not, may I try
one?

Yoshinobu Inoue
Comment 8 Sheldon Hearn 2000-03-17 08:43:09 UTC
On Fri, 17 Mar 2000 02:19:49 +0900, Yoshinobu Inoue wrote:

> Have anyone already started writing one? If not, may I try
> one?

I haven't and you're welcome to.  Run it by me if you like.

Ciao,
Sheldon.
Comment 9 sperber 2000-03-19 11:59:23 UTC
>>>>> "YI" == Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp> writes:

>> >Description:
>> Putting nis anywhere in /etc/host.conf makes basically every network
>> program (like ftp or telnet) segfault upon startup.
>> >How-To-Repeat:
>> Put nis in /etc/host.conf, do ftp ftp.freebsd.org.
>> >Fix:

YI> I confirmed that the problem also happens in my environment,
YI> and the attached patch fixed it in my environment.  Could you
YI> please try this patch, and try ftp or telnet again after
YI> rebuilded and reinstalled src/lib/libc?

YI> Thanks,
YI> Yoshinobu Inoue

YI> Index: name6.c
YI> ===================================================================
YI> RCS file: /home/ncvs/src/lib/libc/net/name6.c,v
YI> retrieving revision 1.6
YI> diff -u -r1.6 name6.c
YI> --- name6.c	2000/03/09 22:52:30	1.6
YI> +++ name6.c	2000/03/16 15:08:32
YI> @@ -840,7 +840,7 @@
YI>  static struct hostent *
YI>  _nis_ghbyname(const char *name, int af, int *errp)
YI>  {
YI> -	struct hostent *hp;
YI> +	struct hostent *hp = NULL;
 
YI> 	if (af == AF_INET) {
YI> 		hp = _gethostbynisname(name, af);

That fixes it, indeed.

Thanks!

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
Comment 10 Mike Barcroft freebsd_committer freebsd_triage 2001-07-22 01:40:04 UTC
State Changed
From-To: open->closed


As per the Audit-Trail, this problem has been solved.