Bug 174262

Comment 1 Edwin Groothuis 2012-12-07 15:10:36 UTC

Class Changed
From-To: change-request->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)

diff -ru zfs-periodic/Makefile zfs-periodic.new/Makefile
--- zfs-periodic/Makefile       2012-11-17 07:01:51.000000000 +0100
+++ zfs-periodic.new/Makefile   2012-12-07 15:41:09.741371448 +0100
@@ -2,15 +2,17 @@
# Date created:                                8 November 2010
# Whom:                                        Peter Ankerstal <peter@pean.org>
#
-# $FreeBSD: ports/sysutils/zfs-periodic/Makefile,v 1.4 2012/11/17 06:01:51 svnexp Exp $
+# $FreeBSD: ports/sysutils/zfs-periodic/Makefile,v 1.3 2012/08/02 09:02:43 cs Exp $
#

PORTNAME=      zfs-periodic
-PORTVERSION=   1.0
-PORTREVISION=  1
+PORTVERSION=   master
+PORTREVISION=  0
CATEGORIES=    sysutils
-MASTER_SITES=  http://www.pean.org/zfs-periodic/
+MASTER_SITES=  https://github.com/ross/zfs-periodic/archive/
+DISTFILES=     master.tar.gz

+FETCH_ARGS=     -Fpr            # work around 302 redirect at guthub
MAINTAINER=    peter@pean.org
COMMENT=       Simple way of maintaining zfs snapshots using the periodic system

diff -ru zfs-periodic/distinfo zfs-periodic.new/distinfo
--- zfs-periodic/distinfo       2011-01-09 22:01:29.000000000 +0100
+++ zfs-periodic.new/distinfo   2012-12-07 14:55:55.050426352 +0100
@@ -1,2 +1,2 @@
-SHA256 (zfs-periodic-1.0.tar.gz) = 3a15951d9f4c1f9b1bdf6bf5f53d48967c1681a13d9e1a16a10314160f563f0c
-SIZE (zfs-periodic-1.0.tar.gz) = 2506
+MD5 (master.tar.gz) = cb306596a1e1dd11908ead949d798f03
+SHA256 (master.tar.gz) = 7e019671cffc62cc42626f8d9b8fd4476122e359e665b78d912edb61c134a220=

Comment 3 Bryan Drewery 2012-12-07 16:27:15 UTC

Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

I'll take it.

Comment 4 Bryan Drewery 2012-12-07 16:48:32 UTC

Hi,

A few tips.

1. We have a USE_GITHUB feature now (see /usr/ports/CHANGES), that will
download the files from github, without needing the FETCH_ARGS workaround.
2. The port must always be updated to point to a snapshot or a specific
commit hash or tag. We can't have 'track master' ports as they don't
have known distinfo. This means that you'll need to keep a specific
version instead of 'master', and use a specific commit.

Here is a patch that does that. It keeps the 1.0 version and adds a date
onto it. To update the port, just the hash and date need to be updated,
or you can tag the repo and update the version/commit/tagname.

http://people.freebsd.org/~bdrewery/patch-zfs-periodic-github.txt

Some other examples that use USE_GITHUB: sysutils/beadm,
sysutils/beadm-devel, ports-mgmt/portmaster, ports-mgmt/portupgrade-devel

-- 
Regards,
Bryan Drewery
bdrewery@freenode/EFNet

On Dec 7, 2012, at 5:48 PM, Bryan Drewery <bdrewery@FreeBSD.org> wrote:

> Hi,
>=20
> A few tips.
>=20
> 1. We have a USE_GITHUB feature now (see /usr/ports/CHANGES), that =
will
> download the files from github, without needing the FETCH_ARGS =
workaround.
> 2. The port must always be updated to point to a snapshot or a =
specific
> commit hash or tag. We can't have 'track master' ports as they don't
> have known distinfo. This means that you'll need to keep a specific
> version instead of 'master', and use a specific commit.
>=20
> Here is a patch that does that. It keeps the 1.0 version and adds a =
date
> onto it. To update the port, just the hash and date need to be =
updated,
> or you can tag the repo and update the version/commit/tagname.
>=20
> http://people.freebsd.org/~bdrewery/patch-zfs-periodic-github.txt
>=20
> Some other examples that use USE_GITHUB: sysutils/beadm,
> sysutils/beadm-devel, ports-mgmt/portmaster, =
ports-mgmt/portupgrade-devel
>=20
> --=20
> Regards,
> Bryan Drewery
> bdrewery@freenode/EFNet
>=20
>=20

Hi!

Thanks for the tips. Didn't know that you could downloads revisions =
directly.

Yes, I know the problem with master, but since I didn't know about your =
method I thought
master was the second best option.

Thanks!=

Comment 6 Bryan Drewery 2012-12-09 01:39:48 UTC

State Changed
From-To: open->closed

Committed. Thanks!