Bug 174545

Summary: [PATCH] sysutils/openipmi (fix pthread/pkg-config issue)
Product: Ports & Packages Reporter: Eric Freeman <freebsdports>
Component: Individual Port(s)Assignee: Steve Wills <swills>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Eric Freeman 2012-12-18 16:50:00 UTC 
I noticed whilst trying to add OpenIPMI functionality to another port (collectd5) that despite having installed the OpenIPMI port the pkg-config command (used by this other software) was failing to locate the OpenIPMI libraries.  For example:

# pkg-config --libs OpenIPMIpthread
Package pthread was not found in the pkg-config search path.
Perhaps you should add the directory containing `pthread.pc'
to the PKG_CONFIG_PATH environment variable
No package 'pthread' found

They were however installed:

# pkg-config --list-all | grep IPMI
OpenIPMIutils                  OpenIPMIutils - Utilities used by the OpenIPMI library.
OpenIPMI                       OpenIPMI - Library to make using IPMI easier
OpenIPMIui                     OpenIPMIui - UI front-end for OpenIPMI
OpenIPMIposix                  OpenIPMIposix - POSIX unthreaded OS handler for OpenIPMI
OpenIPMIpthread                OpenIPMIpthread - Pthread OS handler for OpenIPMI
OpenIPMIcmdlang                OpenIPMIcmdlang - Command language for OpenIPMI
OpenIPMIglib                   OpenIPMIglib - GLIB threaded OS handler for OpenIPMI

The problem it seems is down to the OpenIPMI libs 'requiring' pthread in the 'OpenIPMIpthread.pc.in' file, the lack of pthread.pc caused the pkg-config to exti with a state of 1, stopping the configure script.  As per http://www.freebsd.org/doc/en/books/porters-handbook/dads-pthread.html I think this file should be modified so that the requires 'pthread' is removed and instead a '-pthread' (actually $PTHREAD_LIBS) added to the 'CFlags' line.

I've included the patch to do this and to bump the portrevision, which I thought was probably the right thing to do given I was working on patching another port that would depend on this update.

Regards

Eric

How-To-Repeat: Install OpenIPMI

  pkg-config --libs OpenIPMIpthread
  pkg-config --exists OpenIPMIpthread
  echo $?

etc
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-18 16:50:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->swills

swills@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-18 16:50:09 UTC 
Maintainer of sysutils/openipmi,

Please note that PR ports/174545 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174545

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-18 16:50:10 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Eric Freeman 2013-01-03 18:19:53 UTC 
Just for cross reference purposes, the PR for net-mgmt/collectd5 update I
mentioned that was the trigger for this fix is now in the system as
ports/174953
Comment 5 Steve Wills freebsd_committer freebsd_triage 2013-01-13 21:18:54 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-01-13 21:18:54 UTC 
Author: swills
Date: Sun Jan 13 21:18:41 2013
New Revision: 310337
URL: http://svnweb.freebsd.org/changeset/ports/310337

Log:
  - fix pthread/pkg-config issue
  
  PR:		ports/174545
  Submitted by:	Eric Freeman <freebsdports@chillibear.com>
  Approved by:	maintainer timeout (alex.deiter@gmail.com, >3 weeks)

Added:
  head/sysutils/openipmi/files/patch-OpenIPMIpthread.pc.in   (contents, props changed)
Modified:
  head/sysutils/openipmi/Makefile   (contents, props changed)

Modified: head/sysutils/openipmi/Makefile
==============================================================================
--- head/sysutils/openipmi/Makefile	Sun Jan 13 21:14:23 2013	(r310336)
+++ head/sysutils/openipmi/Makefile	Sun Jan 13 21:18:41 2013	(r310337)
@@ -7,6 +7,7 @@
 
 PORTNAME=	openipmi
 PORTVERSION=	2.0.19
+PORTREVISION=	1
 CATEGORIES=	sysutils
 MASTER_SITES=	SF/${PORTNAME}/OpenIPMI%202.0%20Library
 DISTNAME=	OpenIPMI-${PORTVERSION}

Added: head/sysutils/openipmi/files/patch-OpenIPMIpthread.pc.in
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/sysutils/openipmi/files/patch-OpenIPMIpthread.pc.in	Sun Jan 13 21:18:41 2013	(r310337)
@@ -0,0 +1,11 @@
+--- OpenIPMIpthread.pc.in.orig	2012-12-18 16:15:18.000000000 +0000
++++ OpenIPMIpthread.pc.in	2012-12-18 16:15:29.000000000 +0000
+@@ -6,6 +6,6 @@
+ Name: OpenIPMIpthread
+ Description: Pthread OS handler for OpenIPMI
+ Version: @VERSION@
+-Requires: OpenIPMI pthread
++Requires: OpenIPMI
+ Libs: -L${libdir} -lOpenIPMIutils -lOpenIPMIpthread
+-Cflags: -I${includedir}
++Cflags: -I${includedir} ${PTHREAD_LIBS}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"