Bug 174827

Summary:	Porter's Handbook: Usage of CONFIGURE_ENV in 6.6 Using GNU gettext no longer needed
Product:	Documentation	Reporter:	dominique.goncalves
Component:	Books & Articles	Assignee:	Eitan Adler <eadler>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description dominique.goncalves 2012-12-30 11:00:01 UTC

In the Porter's Handbook section 6.6 Using GNU gettext, there is still reference about using CONFIGURE_ENV for CPPFLAGS and LDFLAGS, it's not needed since r282433

There is probably others references

http://svnweb.freebsd.org/ports?view=revision&revision=282433

Comment 1 Eitan Adler freebsd_committer

2013-02-22 23:33:32 UTC

Responsible Changed
From-To: freebsd-doc->eadler

I'll take it.

Comment 2 dfilter service freebsd_committer

2013-02-23 14:50:12 UTC

Author: eadler
Date: Sat Feb 23 14:49:59 2013
New Revision: 41035
URL: http://svnweb.freebsd.org/changeset/doc/41035

Log:
  Using CONFIGURE_ENV for CPPFLAGS and
  LDFLAGS is not needed since r282433.
  
  PR:		docs/174827
  Submitted by:	Dominique Goncalves <dominique.goncalves@gmail.com>
  Reviewed by:	crees
  Reviewed by:	amdmi3

Modified:
  head/en_US.ISO8859-1/books/porters-handbook/book.xml

Modified: head/en_US.ISO8859-1/books/porters-handbook/book.xml
==============================================================================
--- head/en_US.ISO8859-1/books/porters-handbook/book.xml	Sat Feb 23 12:51:37 2013	(r41034)
+++ head/en_US.ISO8859-1/books/porters-handbook/book.xml	Sat Feb 23 14:49:59 2013	(r41035)
@@ -5726,17 +5726,13 @@ IGNORE=	may not be redistributed because
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 
-GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS}" \
-		LDFLAGS="${LDFLAGS}"</programlisting>
+GNU_CONFIGURE=	yes</programlisting>
 
 	<para>Of course, the code can be more compact if there are no
 	  more flags to pass to <command>configure</command>:</para>
 
 	<programlisting>USE_GETTEXT=	yes
-GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
-		LDFLAGS="-L${LOCALBASE}/lib"</programlisting>
+GNU_CONFIGURE=	yes</programlisting>
       </sect2>
 
       <sect2>
_______________________________________________
svn-doc-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-doc-all
To unsubscribe, send any mail to "svn-doc-all-unsubscribe@freebsd.org"

Comment 3 Eitan Adler freebsd_committer

2013-02-23 15:00:58 UTC

State Changed
From-To: open->closed

Committed. Thanks!