Bug 175054

Summary: [PATCH] multimedia/audacious-plugins 3.3.3 fails building package with option SMB
Product: Ports & Packages Reporter: Eric Kraußer <eric>
Component: Individual Port(s)Assignee: Oliver Lehmann <oliver>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Eric Kraußer 2013-01-06 01:00:00 UTC 
The port fails to create a package if option SMB is set, because the audacious-plugin "Transport smb" was removed 7 months ago from the sources but this plugin binary is in the pkg-plist. (SMB protocol is supported by the plugin "GIO".)

See https://github.com/audacious-media-player/audacious-plugins/commit/2477bd6dc652af907d15acf1abdf4ca2d0030eb5

Fix: Please use the attached patch, it does:

Makefile
- fix the portlint warnings about header and PORT_OPTIONS:MDOCS
- remove option SMB

pkg-plist
- remove entry lib/audacious/Transport/smb.so
- fix the pkg_delete warnings


Patch attached with submission follows:
How-To-Repeat: /usr/ports/multimedia/audacious-plugins # make showconfig
===> The following configuration options are available for audacious-plugins-3.3.3:
..
     SMB=on: SMB protocol
..
===> Use 'make config' to modify these settings



/usr/ports/multimedia/audacious-plugins # make deinstall clean package
..
===>   Registering installation for audacious-plugins-3.3.3
===>  Building package for audacious-plugins-3.3.3
tar: lib/audacious/Transport/smb.so: Cannot stat: No such file or directory
tar: Error exit delayed from previous errors.
pkg_create: make_dist: tar command failed with code 256
*** [do-package] Error code 1
Stop in /usr/ports/multimedia/audacious-plugins.



/usr/ports/multimedia/audacious-plugins # make deinstall
===>  Deinstalling for multimedia/audacious-plugins
===>   Deinstalling audacious-plugins-3.3.3
pkg_delete: file '/usr/local/lib/audacious/Transport/smb.so' doesn't exist
pkg_delete: unable to completely remove directory '/usr/local/lib/audacious/Effect'
pkg_delete: unable to completely remove directory '/usr/local/share/doc/audacious-plugins'
pkg_delete: couldn't entirely delete package `audacious-plugins-3.3.3'
(perhaps the packing list is incorrectly specified?)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-01-06 01:00:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->oliver

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-01-15 15:52:41 UTC 
Author: oliver
Date: Tue Jan 15 15:52:28 2013
New Revision: 310448
URL: http://svnweb.freebsd.org/changeset/ports/310448

Log:
  remove SMB (no longer included)
  add speed-pitch plugin in case of RESAMPLE
  
  PR:             175054
  Submitted by:   Eric Krausser <eric@krausser-edv.de>

Modified:
  head/multimedia/audacious-plugins/Makefile
  head/multimedia/audacious-plugins/pkg-plist

Modified: head/multimedia/audacious-plugins/Makefile
==============================================================================
--- head/multimedia/audacious-plugins/Makefile	Tue Jan 15 15:46:16 2013	(r310447)
+++ head/multimedia/audacious-plugins/Makefile	Tue Jan 15 15:52:28 2013	(r310448)
@@ -30,10 +30,11 @@ PORTDOCS=	AUTHORS
 
 OPTIONS_DEFINE=	DBUS OSS4 SDLOUT ALSA CUE MP3 STATUSICON AOSD AOSDXCOMP \
 				ADPLUG VORBIS FLAC WAVPACK AAC SNDFILE MODPLUG JACK SID \
-				CDAUDIO SCROBBLER MMS  GIO SMB MTP NLS RESAMPLE AMIDI \
+				CDAUDIO SCROBBLER MMS GIO MTP NLS RESAMPLE AMIDI \
 				NOTIFY BS2B FFAUDIO PULSE NEON
 OPTIONS_DEFAULT=	DBUS CUE MP3 STATUSICON AOSD AOSDXCOMP AAC CDAUDIO \
 					SCROBBLER NEON NLS OSS4
+
 ADPLUG_DESC=	ADPLUG decoder
 AMIDI_DESC=	Amidi decoder
 AOSD_DESC=	Audacious OSD
@@ -326,16 +327,6 @@ CONFIGURE_ARGS+=--disable-gio
 PLIST_SUB+=	GIOPLUGIN="@comment "
 .endif
 
-.if ${PORT_OPTIONS:MSMB}
-SAMBA_PORT?=	net/samba34
-LIB_DEPENDS+=	smbclient:${PORTSDIR}/net/samba-libsmbclient
-CONFIGURE_ARGS+=--enable-smb
-PLIST_SUB+=	SMBPLUGIN=""
-.else
-CONFIGURE_ARGS+=--disable-smb
-PLIST_SUB+=	SMBPLUGIN="@comment "
-.endif
-
 .if ${PORT_OPTIONS:MNLS}
 USE_GETTEXT=	yes
 CONFIGURE_ARGS+=--enable-nls
@@ -378,7 +369,7 @@ post-install:
 	@${ECHO_MSG} "ALL PRESETS will be stored in the gconf database."
 	@${ECHO_MSG} ""
 .endif
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
 .for i in ${PORTDOCS}
 	${INSTALL_DATA} ${WRKSRC}/${i} ${DOCSDIR}

Modified: head/multimedia/audacious-plugins/pkg-plist
==============================================================================
--- head/multimedia/audacious-plugins/pkg-plist	Tue Jan 15 15:46:16 2013	(r310447)
+++ head/multimedia/audacious-plugins/pkg-plist	Tue Jan 15 15:52:28 2013	(r310448)
@@ -152,7 +152,6 @@ share/audacious/ui/playlist.ui
 %%MMSPLUGIN%%lib/audacious/Transport/mms.so
 %%NEONPLUGIN%%lib/audacious/Transport/neon.so
 lib/audacious/Transport/unix-io.so
-%%SMBPLUGIN%%lib/audacious/Transport/smb.so
 %%GIOPLUGIN%%lib/audacious/Transport/gio.so
 %%AMIDIPLUGIN%%lib/audacious/Input/amidi-plug.so
 %%AMIDIAPLUGIN%%lib/audacious/Input/amidi-plug/ap-alsa.so
@@ -176,6 +175,7 @@ lib/audacious/Input/psf2.so
 lib/audacious/Effect/stereo.so
 lib/audacious/Effect/crystalizer.so
 %%RESAMPLEPLUGIN%%lib/audacious/Effect/resample.so
+%%RESAMPLEPLUGIN%%lib/audacious/Effect/speed-pitch.so
 lib/audacious/Effect/crossfade.so
 lib/audacious/Effect/compressor.so
 lib/audacious/Effect/ladspa.so
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Oliver Lehmann freebsd_committer freebsd_triage 2013-01-15 15:57:21 UTC 
State Changed
From-To: open->closed

Committed, Thanks!