Bug 17514

Summary: Inconsistent behaviour of "make update" [PATCH]
Product: Base System Reporter: ue <ue>
Component: miscAssignee: Sheldon Hearn <sheldonh>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description ue 2000-03-20 21:30:01 UTC 
The comments in both /usr/src/Makefile.inc1 and /usr/src/Makefile.inc1 state
that "make update" updates the source tree. Since rev. 1.77 of Makefile.inc1,
a "make update" will also update the ports tree. There are good arguments for
and against this behaviour.

The same arguments are valid for the doc tree, too. The current version of
Makefile.inc1 doesn't include code to update the doc tree during make update.

The patch fixes this inconsistency. make update will update the source tree,
the ports tree and the doc tree. The limitations of the original extension
remain: PORTSSUPFILE/DOCSUPFILE need to be defined in make.conf; if you're
cvsup'ing the ports or doc repository, a simple make update WON'T update
your ports/doc tree.

I've also added two knobs called NO_PORTUPDATE and NO_DOCUPDATE. Their
purpose should be obvious.

Tested by:
make update
make -DNO_PORTUPDATE update
make -DNO_DOCUPDATE update
make -DNO_PORTUPDATE -DNO_DOCUPDATE update

How-To-Repeat: 
make update in /usr/src
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-07 15:29:03 UTC 
Responsible Changed
From-To: freebsd-bugs->sheldonh

I'll take this one, although I'll be using NO_PORTSUPDATE 
instead of NO_PORTUPDATE for consistency.
Comment 2 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-07 15:35:51 UTC 
State Changed
From-To: open->analyzed

Remind me to MFC this.
Comment 3 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-15 18:51:07 UTC 
State Changed
From-To: analyzed->closed

Merged onto RELENG_4 as rev 1.141.2.6 of Makefile.inc1 .