Bug 17629

Summary: "almost clone" patch for device snp
Product: Base System Reporter: brooks <brooks>
Component: kernAssignee: Brian Feldman <green>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description brooks 2000-03-28 03:20:01 UTC 
The following patch modifies the snp device to grow automagicaly like
bpf, tun, and pty do.  I had some time on my hands so I looked up phk's
message, "Kernel hacker tasks seek intrested hackers", and this one
looked easy, useful, and somewhat informative so I did it.  The patch
is mostly based on rev 1.53 of bpf.c which did the same thing to bpf.

Fix: The patch is below.  LINT should also be modified changing:

pseudo-device	snp	3	#Snoop device - to look at pty/vty/etc..

to:

pseudo-device	snp		#Snoop device - to look at pty/vty/etc..
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 2000-03-29 13:48:21 UTC 
Responsible Changed
From-To: freebsd-bugs->sheldonh

After chatting to phk (who's kinda busy right now), I'm going to try 
my hand at this one.
Comment 2 Brian Feldman freebsd_committer freebsd_triage 2000-04-02 08:03:08 UTC 
State Changed
From-To: open->feedback

This should be in feedback in Responsible: set to me because I made the accident 
of actually committing this functionality with nearly the same patch, and did 
not notice this PR.  I hope you don't mind, Sheldon.  Thanks for the PR, 
Brooks!  I apologize for not seeing your PR, but don't be discourage at all: 
you did a good job, and I certainly wouldn't mind seeing more (^_^)
Comment 3 Brian Feldman freebsd_committer freebsd_triage 2000-04-02 08:03:08 UTC 
Responsible Changed
From-To: sheldonh->green

I inadvertently committed nearly the same code, so I should be responsible 
for this, I suppose.  I hope you don't mind, Sheldon!
Comment 4 brooks 2000-05-16 20:48:53 UTC 
I was looking at the list of PRs I had opened that were still around and
noticed that this was still in feedback.  Feel free to close it.  I'm
happy with the current situation.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
Comment 5 Brian Feldman freebsd_committer freebsd_triage 2000-05-17 02:31:54 UTC 
State Changed
From-To: feedback->closed

Since the submitter is happy, and a MFC is quite unlikely, it's safe to 
close this :)